New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike out --watch into a separate gem. #2550

Merged
merged 2 commits into from Jun 27, 2014

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Jun 27, 2014

This separate gem will install wdm (I think?) if the OS is Windows. Holds the watch stuff and depends on listen.

parkr added a commit that referenced this pull request Jun 27, 2014

@parkr parkr merged commit 0c8fc63 into master Jun 27, 2014

@parkr parkr deleted the extract-watch branch Jun 27, 2014

parkr added a commit that referenced this pull request Jun 27, 2014

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Jun 29, 2014

@parkr: I just tried it on a clean installation.

While this works without me having to manually install wdm I get:

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation.  All rights reserved.

C:\Users\xmr\Desktop\bootstrap>ruby -v && jekyll -v
ruby 1.9.3p545 (2014-02-24) [i386-mingw32]
jekyll 2.1.0

C:\Users\xmr\Desktop\bootstrap>gem list

*** LOCAL GEMS ***

actionmailer (4.1.2)
actionpack (4.1.2, 4.1.1)
actionview (4.1.2, 4.1.1)
activemodel (4.1.2)
activerecord (4.1.2)
activerecord-sqlserver-adapter (4.1.0)
activeresource (4.0.0)
activesupport (4.1.2, 4.1.1, 3.2.18)
arel (5.0.1.20140414130214)
bigdecimal (1.2.5)
blankslate (3.1.3, 2.1.2.4)
builder (3.2.2)
bundler (1.6.3)
celluloid (0.15.2)
classifier (1.3.4)
coffee-rails (4.0.1)
coffee-script (2.2.0)
coffee-script-source (1.7.0)
colorator (0.1)
erubis (2.7.0)
execjs (2.2.1)
fast-stemmer (1.0.2)
ffi (1.9.3 x86-mingw32)
hike (2.1.3, 1.2.3)
i18n (0.6.9)
io-console (0.4.2)
jekyll (2.1.0)
jekyll-coffeescript (1.0.0)
jekyll-gist (1.1.0)
jekyll-paginate (1.0.0)
jekyll-sass-converter (1.0.0)
jekyll-watch (1.0.0)
journey (1.0.4)
jquery-rails (3.1.1)
json (1.8.1)
kramdown (1.4.0)
liquid (2.6.1)
listen (2.7.9)
mail (2.6.1, 2.5.4)
mercenary (0.3.3)
mime-types (2.3, 1.25.1)
minitest (5.3.5)
multi_json (1.10.1)
parslet (1.6.1, 1.5.0)
pg (0.17.1 x86-mingw32)
polyglot (0.3.5)
posix-spawn (0.3.8)
pygments.rb (0.6.0)
rack (1.5.2)
rack-cache (1.2)
rack-ssl (1.4.1)
rack-test (0.6.2)
rails (4.1.2)
rails-observers (0.1.2)
railties (4.1.2)
rake (10.3.1, 0.9.2.2)
rb-fsevent (0.9.4)
rb-inotify (0.9.5)
rb-readline (0.5.1)
rdoc (3.9.5)
redcarpet (3.1.2)
rubygems-update (2.3.0)
rubyzip (1.1.3)
safe_yaml (1.0.3)
sass (3.2.19)
sass-rails (4.0.3)
sprockets (2.11.0)
sprockets-rails (2.1.3)
sqlite3 (1.3.9 x86-mingw32)
sqlite3-ruby (1.3.3)
thor (0.19.1)
thread_safe (0.3.3)
tilt (1.4.1)
timers (1.1.0)
tiny_tds (0.6.1 x86-mingw32)
toml (0.1.1)
treetop (1.4.15)
tzinfo (1.1.0)
yajl-ruby (1.1.0 x86-mingw32)

C:\Users\xmr\Desktop\bootstrap>jekyll serve --watch
Configuration file: C:/Users/xmr/Desktop/bootstrap/_config.yml
            Source: docs
       Destination: _gh_pages
      Generating...
C:/RailsInstaller/Ruby1.9.3/lib/ruby/gems/1.9.1/gems/posix-spawn-0.3.8/lib/posix/spawn.rb:162: warning: cannot close fd before spawn
'which' is not recognized as an internal or external command, operable program or batch file.
                    done.
  Please add the following to your Gemfile to avoid polling for changes:
    require 'rbconfig'
    if RbConfig::CONFIG['target_os'] =~ /mswin|mingw|cygwin/i
      gem 'wdm', '>= 0.1.0'
    end

 Auto-regeneration: enabled for 'docs'
Configuration file: C:/Users/xmr/Desktop/bootstrap/_config.yml
    Server address: http://0.0.0.0:9001//
  Server running... press ctrl-c to stop.

@XhmikosR XhmikosR referenced this pull request Jun 29, 2014

Closed

Update for 2.1.0 #16

@parkr

This comment has been minimized.

Member

parkr commented Jun 29, 2014

No, you'll still need wdm: jekyll/jekyll-watch#1

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Jun 29, 2014

I thought the whole idea of this was to make wdm install automatically if needed?

@XhmikosR

This comment has been minimized.

Contributor

XhmikosR commented Jun 29, 2014

Nevermind, I see that this is the actual issue. :)

I hope this gets sorted eventually. Also, do not hesitate to CC me if you need something tested on Windows before you make a release.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.