Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Use category in downcase only for URL #2571
I don't think this leaves out that option for later. This immediately solves a problem that can be refined later with a better solution. Since this really adds no major debt at all to that idea to begin with, IMO it wouldn't hurt to just merge it to solve the problem and then flag the ticket as incomplete and make a note of what should happen in the future.
That's just my opinion on code that introduces no real debt but solves an immediate problem.
My thought is if one is manipulating categories in Liquid and providing a URL related to it (maybe you've created a category page where all your posts of a certain category are printed on a given page) or checking if a post has a given category. In the current model, any capitalization variation on the category is eliminated, making it quite easy. If we change this behaviour, we may find ourselves with a lot of broken sites. This almost feels like a 3.0 change because it has the potential to cause significant template changes. It's certainly possible to change the templates to conform, but this PR in its present form does not provide any backwards-compatibility or deprecation messages.
We want to be able to have capitalization in the printed representation of the category, but any logic around it (esp comparison) should be case-insensitive.