Proof site with html-proofer on change #2605

Merged
merged 4 commits into from Jul 16, 2014

Conversation

Projects
None yet
4 participants
@alfredxing
Member

alfredxing commented Jul 16, 2014

Adds a script to the CI build to proof the Jekyll site if it has been changed in the last commit or PR, as suggested in #2601.

First checks with git to see if the site/ directory has been changed. If it has, then continue, otherwise exit with code 0.

If html-proofer is not installed, install its nokogiri dependency with system libraries so it builds a lot faster. Then simply build the site with Jekyll and proof it.

@@ -1,4 +1,5 @@
#! /bin/bash
script/branding
+script/proof

This comment has been minimized.

@parkr

parkr Jul 16, 2014

Member

Let's run this after all the tests! We could also scope the tests so they only run if a file was changed that would affect it.

@parkr

parkr Jul 16, 2014

Member

Let's run this after all the tests! We could also scope the tests so they only run if a file was changed that would affect it.

parkr added a commit that referenced this pull request Jul 16, 2014

@parkr parkr merged commit 86cbffb into jekyll:master Jul 16, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jul 16, 2014

@penibelst

This comment has been minimized.

Show comment
Hide comment
@penibelst

penibelst Jul 16, 2014

Member

This is awesome.

Irony at https://travis-ci.org/jekyll/jekyll/jobs/30032882#L126:

Notice: for 10x faster LSI support, please install http://rb-gsl.rubyforge.org/

Rubyforge is dead.

Member

penibelst commented Jul 16, 2014

This is awesome.

Irony at https://travis-ci.org/jekyll/jekyll/jobs/30032882#L126:

Notice: for 10x faster LSI support, please install http://rb-gsl.rubyforge.org/

Rubyforge is dead.

@penibelst penibelst referenced this pull request Jul 16, 2014

Closed

Proof the proofer #2606

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Jul 16, 2014

Member

@penibelst Speaking of RubyForge, we have quite a few links to it on our site that are broken. Any ideas what we should do with them?

Member

alfredxing commented Jul 16, 2014

@penibelst Speaking of RubyForge, we have quite a few links to it on our site that are broken. Any ideas what we should do with them?

@penibelst

This comment has been minimized.

Show comment
Hide comment
@penibelst

penibelst Jul 16, 2014

Member

I would just remove the links and the related content. If people break the web, we don’t have to play bloodhounds.

Member

penibelst commented Jul 16, 2014

I would just remove the links and the related content. If people break the web, we don’t have to play bloodhounds.

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Jul 16, 2014

Member

Sure. I'll fix it up after the latest Travis build finishes.

Member

alfredxing commented Jul 16, 2014

Sure. I'll fix it up after the latest Travis build finishes.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.