New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friendly date error #2649

Merged
merged 2 commits into from Aug 2, 2014

Conversation

Projects
None yet
3 participants
@alfredxing
Member

alfredxing commented Jul 30, 2014

Throw a friendly error message when the date in the YAML front matter of a post is invalid (similar to the behaviour when the date in the filename is invalid).

Also, use relative_path instead of path for both errors to make it easier to find the infringing file.

Addresses #2641.

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Jul 30, 2014

Member

For some reason the CI build didn't trigger, but I've CI'ed my fork as well, so here's the build from that: https://travis-ci.org/alfredxing/jekyll/builds/31271127

Build Status

Member

alfredxing commented Jul 30, 2014

For some reason the CI build didn't trigger, but I've CI'ed my fork as well, so here's the build from that: https://travis-ci.org/alfredxing/jekyll/builds/31271127

Build Status

Show outdated Hide outdated lib/jekyll/post.rb
@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Aug 1, 2014

Member

Rebased.

Member

alfredxing commented Aug 1, 2014

Rebased.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 2, 2014

Member

Oh crap #2664 totally borked this. Neeeeds another rebase. ❤️

Member

parkr commented Aug 2, 2014

Oh crap #2664 totally borked this. Neeeeds another rebase. ❤️

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Aug 2, 2014

Member

Done! 🆗

Member

alfredxing commented Aug 2, 2014

Done! 🆗

alfredxing added some commits Jul 30, 2014

Add friendly error message for invalid dates
Catch the `ArgumentError` when parsing dates from the YAML front
matter

@parkr parkr merged commit e75dc74 into jekyll:master Aug 2, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Aug 2, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 2, 2014

Member

Almost looks like we need a centralize Utils method for parsing dates!

Member

parkr commented Aug 2, 2014

Almost looks like we need a centralize Utils method for parsing dates!

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Aug 2, 2014

Member

@parkr Can we put that off 'til 3.0? 😅

Member

alfredxing commented Aug 2, 2014

@parkr Can we put that off 'til 3.0? 😅

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.