New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only include lib files in the gem #2671

Merged
merged 2 commits into from Aug 1, 2014

Conversation

Projects
None yet
3 participants
@gjtorikian
Member

gjtorikian commented Jul 31, 2014

Resolves #2670.

Show outdated Hide outdated jekyll.gemspec
@@ -20,7 +20,7 @@ Gem::Specification.new do |s|
s.email = 'tom@mojombo.com'
s.homepage = 'https://github.com/jekyll/jekyll'
s.files = `git ls-files`.split($/)
s.files = Dir["lib/**/*.rb"]

This comment has been minimized.

@parkr

parkr Jul 31, 2014

Member

we need the site_template files too. Can you do the git ls-files but select for path.start_with?("lib")?

@parkr

parkr Jul 31, 2014

Member

we need the site_template files too. Can you do the git ls-files but select for path.start_with?("lib")?

parkr added a commit that referenced this pull request Aug 1, 2014

@parkr parkr merged commit f6682de into jekyll:master Aug 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Aug 1, 2014

parkr added a commit that referenced this pull request Aug 1, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 1, 2014

Member

Ok so this excluded the bin/jekyll file. Modified it a bit and it should all work. Also need to remove test_files.

Member

parkr commented Aug 1, 2014

Ok so this excluded the bin/jekyll file. Modified it a bit and it should all work. Also need to remove test_files.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.