New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamlining front matter wording (instead of front-matter/frontmatter) #2674

Merged
merged 2 commits into from Aug 1, 2014

Conversation

Projects
None yet
3 participants
@kleinfreund
Contributor

kleinfreund commented Aug 1, 2014

Fixes #2396.

@kleinfreund

This comment has been minimized.

Show comment
Hide comment
@kleinfreund

kleinfreund Aug 1, 2014

Contributor

Looks like HTML proofer is choking on the internal hash, because it can't find the referenced ID on this page. This is probably due to the ID being auto generated on build, right?

Contributor

kleinfreund commented Aug 1, 2014

Looks like HTML proofer is choking on the internal hash, because it can't find the referenced ID on this page. This is probably due to the ID being auto generated on build, right?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 1, 2014

Member

Looks like HTML proofer is choking on the internal hash, because it can't find the referenced ID

It must have changed. It checks the ID's internally and can't find that hash. Maybe it has become #front-matter-defaults?

Member

parkr commented Aug 1, 2014

Looks like HTML proofer is choking on the internal hash, because it can't find the referenced ID

It must have changed. It checks the ID's internally and can't find that hash. Maybe it has become #front-matter-defaults?

@kleinfreund

This comment has been minimized.

Show comment
Hide comment
@kleinfreund

kleinfreund Aug 1, 2014

Contributor

Ah, woops. It is indeed #front-matter-defaults now, because the heading was Frontmatter defaults before, I guess.

Contributor

kleinfreund commented Aug 1, 2014

Ah, woops. It is indeed #front-matter-defaults now, because the heading was Frontmatter defaults before, I guess.

@kleinfreund

This comment has been minimized.

Show comment
Hide comment
@kleinfreund

kleinfreund Aug 1, 2014

Contributor

Passes now, you were right @parkr. Thanks. 👍

Contributor

kleinfreund commented Aug 1, 2014

Passes now, you were right @parkr. Thanks. 👍

parkr added a commit that referenced this pull request Aug 1, 2014

@parkr parkr merged commit b63d113 into jekyll:master Aug 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Aug 1, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.