New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing indentation in the docs #2717

Merged
merged 1 commit into from Aug 10, 2014

Conversation

Projects
None yet
3 participants
@hockeybuggy
Contributor

hockeybuggy commented Aug 10, 2014

Hey,

This PR fixes some indentation that was causing a few paragraphs to be interpreted as code blocks. With the indentation the configuration page scrolls horizontally and looks weird.

@hockeybuggy

This comment has been minimized.

Show comment
Hide comment
@hockeybuggy

hockeybuggy Aug 10, 2014

Contributor

Huh. Not totally sure why the build failed but it seems to be from the same error that is causing #2708 to fail. Since the other PR fixes a typo in continuous-integration.md, I don't think it is something I did.

Conversion error: Jekyll::Converters::Markdown encountered an error converting '_docs/configuration.md'.

/home/travis/build/jekyll/jekyll/vendor/bundle/ruby/2.0.0/gems/kramdown-1.4.1/lib/kramdown/parser/base.rb:92:in `encode': "\xE2" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)

I am not even sure why this method is engaged since configuration.md appears to be UTF-8

Anyone have any ideas?

Contributor

hockeybuggy commented Aug 10, 2014

Huh. Not totally sure why the build failed but it seems to be from the same error that is causing #2708 to fail. Since the other PR fixes a typo in continuous-integration.md, I don't think it is something I did.

Conversion error: Jekyll::Converters::Markdown encountered an error converting '_docs/configuration.md'.

/home/travis/build/jekyll/jekyll/vendor/bundle/ruby/2.0.0/gems/kramdown-1.4.1/lib/kramdown/parser/base.rb:92:in `encode': "\xE2" from ASCII-8BIT to UTF-8 (Encoding::UndefinedConversionError)

I am not even sure why this method is engaged since configuration.md appears to be UTF-8

Anyone have any ideas?

@hockeybuggy

This comment has been minimized.

Show comment
Hide comment
@hockeybuggy

hockeybuggy Aug 10, 2014

Contributor

I think that this might have curl 401ing.

This is the line in this PR: https://travis-ci.org/jekyll/jekyll/jobs/32164732#L39
And this is the line in the other failing RP(#2708): https://travis-ci.org/jekyll/jekyll/jobs/31884833#L39

This build did not 401 and passed: https://travis-ci.org/jekyll/jekyll/jobs/32166333#L44

Not sure why this might cause an error...

Contributor

hockeybuggy commented Aug 10, 2014

I think that this might have curl 401ing.

This is the line in this PR: https://travis-ci.org/jekyll/jekyll/jobs/32164732#L39
And this is the line in the other failing RP(#2708): https://travis-ci.org/jekyll/jekyll/jobs/31884833#L39

This build did not 401 and passed: https://travis-ci.org/jekyll/jekyll/jobs/32166333#L44

Not sure why this might cause an error...

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 10, 2014

Member

@hockeybuggy If the rebund stuff (our gem cache) affects this, it is likely due to an old version of Kramdown being used when the 401 is not present so it passes. A newer version may be more strict.

Member

parkr commented Aug 10, 2014

@hockeybuggy If the rebund stuff (our gem cache) affects this, it is likely due to an old version of Kramdown being used when the 401 is not present so it passes. A newer version may be more strict.

@parkr parkr merged commit d74b179 into jekyll:master Aug 10, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

parkr added a commit that referenced this pull request Aug 10, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

@hockeybuggy hockeybuggy deleted the hockeybuggy:fenced-paragraphs branch May 19, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.