New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Reading Documents, Respect `encoding` Option #2720

Merged
merged 3 commits into from Aug 10, 2014

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Aug 10, 2014

This fixes the issue @hockeybuggy found in #2717.

parkr added a commit that referenced this pull request Aug 10, 2014

@parkr parkr merged commit 11373ac into master Aug 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the read-in-utf8 branch Aug 10, 2014

parkr added a commit that referenced this pull request Aug 10, 2014

@hockeybuggy

This comment has been minimized.

Show comment
Hide comment
@hockeybuggy

hockeybuggy Aug 10, 2014

Contributor

👍 Thanks for the shoutout.
#2708 can likely also be merged since it failed the same way #2717 did.

Contributor

hockeybuggy commented Aug 10, 2014

👍 Thanks for the shoutout.
#2708 can likely also be merged since it failed the same way #2717 did.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 10, 2014

Member

Yes indeed! Thanks.

Member

parkr commented Aug 10, 2014

Yes indeed! Thanks.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.