New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front Matter default types should always be pluralized. #2732

Merged
merged 5 commits into from Aug 12, 2014

Conversation

Projects
None yet
2 participants
@parkr
Member

parkr commented Aug 12, 2014

This PR also supports the drafts type per 9c090c8.

/cc @benbalter @kleinfreund

parkr added some commits Aug 12, 2014

Ask about 'Draft' before asking about 'Post'
`Draft`s are a subclass of `Post` so `draft.is_a?(Post)` will return
`true`, thus making all `Draft`s `Post`s, which is not desired. If
asking about `Draft` first, then we avoid this problem.

Fixes #2726

@parkr parkr merged commit 871e425 into master Aug 12, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@parkr parkr deleted the type-should-be-similar-in-number branch Aug 12, 2014

@parkr parkr added the UX label Aug 12, 2014

@parkr parkr added this to the 2.3 milestone Aug 12, 2014

parkr added a commit that referenced this pull request Aug 12, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.