Find variables in _config.yaml by searching with relative file path. #2774

Merged
merged 1 commit into from Jan 17, 2015

Conversation

Projects
None yet
3 participants
@dziemian007
Contributor

dziemian007 commented Aug 19, 2014

This basically will fix #2371. Please check/reproduce there.

When FrontmatterDefaults tries to find matching sets from config file, lookup by path fails if it also contains "_posts" part. So instead of matching path like "/all/pages/2014-01-01-test.md" it will try to also match "/all/pages/_posts/2014-01-01-test.md".

Without the fix, we won't be able to customize via _config.yml files not assigned to any category (located at root /_posts)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 29, 2014

Member

/cc @jekyll/core 👀

Member

parkr commented Dec 29, 2014

/cc @jekyll/core 👀

@parkr parkr added the fix label Dec 29, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 17, 2015

Member

LGTM.

Member

parkr commented Jan 17, 2015

LGTM.

@parkr parkr added this to the 3.0 milestone Jan 17, 2015

parkr added a commit that referenced this pull request Jan 17, 2015

@parkr parkr merged commit 6d9b4c2 into jekyll:master Jan 17, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jan 17, 2015

@natoverse natoverse referenced this pull request in atsid/www.atsid.com Dec 15, 2015

Closed

(#35) - Add blog section #37

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.