New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Jekyll.sanitized_path when adding static files to Collections. #2849

Merged
merged 1 commit into from Aug 31, 2014

Conversation

Projects
None yet
2 participants
@parkr
Member

parkr commented Aug 29, 2014

h/t @benbalter #2737 (comment)
Not sure if the previous code can be exploited, but being super safe is never a bad thing.

Use Jekyll.sanitized_path when adding static files to Collections.
h/t @benbalter #2737 (comment)
Not sure if the previous code can be exploited, but being super safe is never a bad thing.
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Aug 31, 2014

Member

I couldn't figure out how to exploit this but I changed it anyway. Look ok, @benbalter?

Member

parkr commented Aug 31, 2014

I couldn't figure out how to exploit this but I changed it anyway. Look ok, @benbalter?

@parkr parkr merged commit 27d3126 into master Aug 31, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the maybe-secure-doc-reading branch Aug 31, 2014

parkr added a commit that referenced this pull request Aug 31, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.