New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a slugify Liquid filter #2880

Merged
merged 3 commits into from Sep 7, 2014

Conversation

Projects
None yet
4 participants
@kansaichris

In #2864, @alfredxing noted:

I'm beginning to think that a sluggify function would turn out to be immensely useful throughout the rest of the project as well, and since it doesn't really have anything to do with Documents in the first place, would it be better to move it to Utils?

I agreed. I think we can do even better, though, and provide this functionality as a Liquid filter.

@parkr @gjtorikian @alfredxing What do you think? Could you suggest some more strings to test to ensure that this feature works as expected?

@parkr parkr merged commit c3dc5cc into jekyll:master Sep 7, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Sep 7, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 7, 2014

Member

Looks great, thanks @kansaichris!

Member

parkr commented Sep 7, 2014

Looks great, thanks @kansaichris!

@kansaichris kansaichris deleted the kansaichris:slugify-liquid-filter branch Sep 7, 2014

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Sep 8, 2014

Member

Awesome, thanks for working on this!

Member

alfredxing commented Sep 8, 2014

Awesome, thanks for working on this!

@kansaichris

This comment has been minimized.

Show comment
Hide comment
@kansaichris

kansaichris Sep 8, 2014

@imathis In case you're interested, this is the slugify filter that I was working on. 😄

@imathis In case you're interested, this is the slugify filter that I was working on. 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.