New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Point Liquid links to Liquid’s Github wiki #2887

Merged
merged 1 commit into from Sep 14, 2014

Conversation

Projects
None yet
3 participants
@pathawks
Member

pathawks commented Sep 9, 2014

I did not change the number of links; even though they're all pointing to the same page, they point to specific anchors within that page.

Are there any other Liquid links that should be updated?

Hopefully resolves questions like #2883

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 9, 2014

Member

Fail is unrelated.

Gem::RemoteFetcher::FetchError: Errno::ETIMEDOUT: Connection timed out - connect(2) for "rubygems.org" port 443 (https://rubygems.org/gems/rake-10.3.2.gem)
An error occurred while installing rake (10.3.2), and Bundler cannot continue.
Make sure that `gem install rake -v '10.3.2'` succeeds before bundling.
The command "bundle install --path vendor/bundle" failed 3 times.
The command "travis_retry bundle install --path vendor/bundle" failed and exited with 5 during .
Your build has been stopped.
Member

pathawks commented Sep 9, 2014

Fail is unrelated.

Gem::RemoteFetcher::FetchError: Errno::ETIMEDOUT: Connection timed out - connect(2) for "rubygems.org" port 443 (https://rubygems.org/gems/rake-10.3.2.gem)
An error occurred while installing rake (10.3.2), and Bundler cannot continue.
Make sure that `gem install rake -v '10.3.2'` succeeds before bundling.
The command "bundle install --path vendor/bundle" failed 3 times.
The command "travis_retry bundle install --path vendor/bundle" failed and exited with 5 during .
Your build has been stopped.
@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 9, 2014

Member

Nearly identical to #2888

If one is merged, the other can be closed.

Member

pathawks commented Sep 9, 2014

Nearly identical to #2888

If one is merged, the other can be closed.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 9, 2014

Member

I'll go with this one for now, given its higher level of detail.

Let's change the link on the other pages you have listed in the description as well, but maybe to a marketing page for Liquid instead of its docs? Could even be the repo's readme if you wanted, though that'd be more a last resort probably.

Member

parkr commented Sep 9, 2014

I'll go with this one for now, given its higher level of detail.

Let's change the link on the other pages you have listed in the description as well, but maybe to a marketing page for Liquid instead of its docs? Could even be the repo's readme if you wanted, though that'd be more a last resort probably.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 9, 2014

Member

but maybe to a marketing page for Liquid instead of its docs?

What would you suggest?

  • docs.shopify.com has some great info, but is very shopify centric.
  • liquidmarkup.org has no information that would be help someone just getting her feet wet.
  • Shopify/liquid/wiki has the best info for somebody ready to dive in, but might assume the user knows too much...
Member

pathawks commented Sep 9, 2014

but maybe to a marketing page for Liquid instead of its docs?

What would you suggest?

  • docs.shopify.com has some great info, but is very shopify centric.
  • liquidmarkup.org has no information that would be help someone just getting her feet wet.
  • Shopify/liquid/wiki has the best info for somebody ready to dive in, but might assume the user knows too much...
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 9, 2014

Member

Yeah, none of those options will work. What do you think about the Liquid readme?

Member

parkr commented Sep 9, 2014

Yeah, none of those options will work. What do you think about the Liquid readme?

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 9, 2014

Member

The readme shows a very brief example of Liquid, but spends more time on back-end stuff; equivalent to liquidmarkup.org

😒

Member

pathawks commented Sep 9, 2014

The readme shows a very brief example of Liquid, but spends more time on back-end stuff; equivalent to liquidmarkup.org

😒

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 9, 2014

Member

Alright, use https://github.com/Shopify/liquid/wiki then, please!

Member

parkr commented Sep 9, 2014

Alright, use https://github.com/Shopify/liquid/wiki then, please!

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 9, 2014

Member

Will do, tonight.

Member

pathawks commented Sep 9, 2014

Will do, tonight.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 9, 2014

Member

Will rebase tonight, but does this look alright?

Member

pathawks commented Sep 9, 2014

Will rebase tonight, but does this look alright?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 9, 2014

Member

Do we need the trailing slash for the base wiki page?

Member

parkr commented Sep 9, 2014

Do we need the trailing slash for the base wiki page?

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 9, 2014

Member

Do we need the trailing slash for the base wiki page?

Nope. Good catch.

Member

pathawks commented Sep 9, 2014

Do we need the trailing slash for the base wiki page?

Nope. Good catch.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 9, 2014

Member

Awesome. If you would please squash and rebase, I'd be very grateful! I'll merge this once that goes through.

Member

parkr commented Sep 9, 2014

Awesome. If you would please squash and rebase, I'd be very grateful! I'll merge this once that goes through.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 9, 2014

Member

On my phone right now (if you can imagine); I’ll be able to squash in a few hours.

Member

pathawks commented Sep 9, 2014

On my phone right now (if you can imagine); I’ll be able to squash in a few hours.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 9, 2014

Member

On my phone right now (if you can imagine)

I do a lot of code review and such on my phone – I hear ya, it's tough to get real work done on it. Take your time.

Member

parkr commented Sep 9, 2014

On my phone right now (if you can imagine)

I do a lot of code review and such on my phone – I hear ya, it's tough to get real work done on it. Take your time.

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 10, 2014

Member

It's green! 🚢

Member

pathawks commented Sep 10, 2014

It's green! 🚢

Point Liquid links to Liquid’s Github wiki
Provide a more helpful resource for questions like #2883
@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Sep 14, 2014

Member

Where do we stand on this?

Member

pathawks commented Sep 14, 2014

Where do we stand on this?

@parkr parkr merged commit bf1a232 into jekyll:master Sep 14, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Sep 14, 2014

@pathawks pathawks deleted the pathawks:Update-Liquid-Links branch Sep 15, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.