Use relative path for `path` Liquid variable in Documents #2908

Merged
merged 2 commits into from Dec 29, 2014

Conversation

Projects
None yet
3 participants
@alfredxing
Member

alfredxing commented Sep 11, 2014

Addresses #2897. The only change here is in the to_liquid method since the rest of the file heavily depends on the original path variable.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Sep 11, 2014

Member

This is a breaking change 😦

Is there a way to mitigate that? I can't think of one.

Member

parkr commented Sep 11, 2014

This is a breaking change 😦

Is there a way to mitigate that? I can't think of one.

Keep backwards compatibility
Re-add `relative_path` Liquid variable too keep compatibility
@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Sep 12, 2014

Member

Oh, it's just because I deleted the relative_path Liquid variable. Adding it back (too keep compatibility) should fix this.

Member

alfredxing commented Sep 12, 2014

Oh, it's just because I deleted the relative_path Liquid variable. Adding it back (too keep compatibility) should fix this.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 5, 2014

Member

We have to wait until 3.0 to do this because it breaks things. :/

Member

parkr commented Oct 5, 2014

We have to wait until 3.0 to do this because it breaks things. :/

@parkr parkr added this to the 3.0 milestone Oct 5, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 15, 2014

Member

Because this changes the page.path variable would change, this is a breaking change.

Member

parkr commented Oct 15, 2014

Because this changes the page.path variable would change, this is a breaking change.

@parkr parkr merged commit e39dfa3 into jekyll:master Dec 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Dec 29, 2014

@parkr parkr added the fix label Dec 29, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.