Unescape Document output path #2924

Merged
merged 1 commit into from Dec 29, 2014

Conversation

Projects
None yet
3 participants
@nitoyon
Contributor

nitoyon commented Sep 14, 2014

Document#destination wasn't unescaped properly.

For example, when we have a document named _langs/c#.md,
we expect its url to be /langs/c#.html,
but it was actually /langs/c%23.html.

We now unecape URL at Document#destination like Post#destination and
Page#destination.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 5, 2014

Member

The discussion for this is happening elsewhere, I think. For a URL, # has to be URL encoded.

Member

parkr commented Oct 5, 2014

The discussion for this is happening elsewhere, I think. For a URL, # has to be URL encoded.

@parkr

This comment has been minimized.

Show comment
Hide comment
Member

parkr commented Oct 5, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 29, 2014

Member

Can you rebase on master?

Member

parkr commented Dec 29, 2014

Can you rebase on master?

Unescape Document output path
Document#destination wasn't unescaped properly.

For example, when we have a document named '_langs/c#.md',
we expect its url to be '/langs/c#.html',
but it was actually '/langs/c%23.html'.

We now unecape URL at Document#destination like Post#destination and
Page#destination.
@nitoyon

This comment has been minimized.

Show comment
Hide comment
@nitoyon

nitoyon Dec 29, 2014

Contributor

@parkr rebased!

Contributor

nitoyon commented Dec 29, 2014

@parkr rebased!

@parkr parkr merged commit 9b81f29 into jekyll:master Dec 29, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Dec 29, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.