New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix head.html indentation #2973

Merged
merged 1 commit into from Oct 5, 2014

Conversation

Projects
None yet
4 participants
@tkrotoff
Contributor

tkrotoff commented Oct 5, 2014

2 spaces instead of 4: all Jekyll .html files are indented with 2 spaces, head.html was not

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 5, 2014

Member

GitHub does this so I guess this is OK. Thx!

Member

parkr commented Oct 5, 2014

GitHub does this so I guess this is OK. Thx!

@parkr parkr merged commit b965d44 into jekyll:master Oct 5, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Oct 5, 2014

@tkrotoff

This comment has been minimized.

Show comment
Hide comment
@tkrotoff

tkrotoff Oct 6, 2014

Contributor

@parkr what do you mean by GitHub does it?

Contributor

tkrotoff commented Oct 6, 2014

@parkr what do you mean by GitHub does it?

@brianzelip

This comment has been minimized.

Show comment
Hide comment
@brianzelip

brianzelip Oct 6, 2014

I think he means GitHub implements soft-tabs w/ 2 spaces in their markup,
so why not merge this pr.

On Mon, Oct 6, 2014 at 2:46 AM, Tanguy Krotoff notifications@github.com
wrote:

@parkr https://github.com/parkr what do you mean by GitHub does it?


Reply to this email directly or view it on GitHub
#2973 (comment).

brianzelip commented Oct 6, 2014

I think he means GitHub implements soft-tabs w/ 2 spaces in their markup,
so why not merge this pr.

On Mon, Oct 6, 2014 at 2:46 AM, Tanguy Krotoff notifications@github.com
wrote:

@parkr https://github.com/parkr what do you mean by GitHub does it?


Reply to this email directly or view it on GitHub
#2973 (comment).

@tkrotoff

This comment has been minimized.

Show comment
Hide comment
@tkrotoff

tkrotoff Oct 6, 2014

Contributor

@brianzelip whatever convention you follow; all code should stick to it: all Jekyll .html files are 2 spaces except head.html who was 4 spaces

Contributor

tkrotoff commented Oct 6, 2014

@brianzelip whatever convention you follow; all code should stick to it: all Jekyll .html files are 2 spaces except head.html who was 4 spaces

@tkrotoff tkrotoff deleted the tkrotoff:indent-head.html branch Dec 1, 2014

@tkrotoff tkrotoff restored the tkrotoff:indent-head.html branch Dec 26, 2014

@tkrotoff tkrotoff deleted the tkrotoff:indent-head.html branch Jan 29, 2015

tkrotoff added a commit to tkrotoff/osteo15.com that referenced this pull request Feb 16, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.