New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Liquid 3.0.0 #3002

Merged
merged 5 commits into from Dec 27, 2014

Conversation

Projects
None yet
5 participants
@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Oct 14, 2014

Member

Replace each Jekyll::Tags::HighlightBlock.new in test_tags.rb with Jekyll::Tags::HighlightBlock.parse (and add an empty options hash at the end of each call), and all of the unit tests pass (Shopify/liquid#321).

Member

alfredxing commented Oct 14, 2014

Replace each Jekyll::Tags::HighlightBlock.new in test_tags.rb with Jekyll::Tags::HighlightBlock.parse (and add an empty options hash at the end of each call), and all of the unit tests pass (Shopify/liquid#321).

@parkr parkr added this to the 3.0 milestone Oct 22, 2014

@fw42 fw42 referenced this pull request Nov 7, 2014

Merged

Release 3-0-0-rc2 #483

@parkr parkr referenced this pull request Nov 12, 2014

Closed

Update kramdown to 1.5.0 #3028

@parkr parkr changed the title from Try liquid 3. to Upgrade to Liquid 3.0.0 Nov 13, 2014

@parkr parkr self-assigned this Nov 13, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 27, 2014

Member

Thinking about releasing this in Jekyll v2.6.0 with incremental regeneration if it doesn't break sites.

Member

parkr commented Nov 27, 2014

Thinking about releasing this in Jekyll v2.6.0 with incremental regeneration if it doesn't break sites.

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Nov 27, 2014

Member

I would be careful though since this is a major version bump for Liquid. Maybe ask the Liquid team if there were any breaking changes on their end? What do you think @fw42?

Member

alfredxing commented Nov 27, 2014

I would be careful though since this is a major version bump for Liquid. Maybe ask the Liquid team if there were any breaking changes on their end? What do you think @fw42?

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Nov 29, 2014

Contributor

How about rebasing and squashing the 3 version bump patches into 1?

Contributor

XhmikosR commented Nov 29, 2014

How about rebasing and squashing the 3 version bump patches into 1?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 30, 2014

Member

Sure!

Member

parkr commented Nov 30, 2014

Sure!

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Nov 30, 2014

Contributor

Thanks!

Contributor

XhmikosR commented Nov 30, 2014

Thanks!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 16, 2014

Member

liquid-c doesn't seem to provide any benefit. @pushrax, anything I'm missing here?

Member

parkr commented Dec 16, 2014

liquid-c doesn't seem to provide any benefit. @pushrax, anything I'm missing here?

@parkr parkr added the Enhancement label Dec 22, 2014

@pushrax

This comment has been minimized.

Show comment
Hide comment
@pushrax

pushrax Dec 23, 2014

@parkr the liquid-c gem on rubygems is really out of date and does basically nothing, I'll publish a new version when I have a chance.

pushrax commented Dec 23, 2014

@parkr the liquid-c gem on rubygems is really out of date and does basically nothing, I'll publish a new version when I have a chance.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 23, 2014

Member

@parkr the liquid-c gem on rubygems is really out of date and does basically nothing, I'll publish a new version when I have a chance.

Thanks, @pushrax!!

Member

parkr commented Dec 23, 2014

@parkr the liquid-c gem on rubygems is really out of date and does basically nothing, I'll publish a new version when I have a chance.

Thanks, @pushrax!!

@pushrax

This comment has been minimized.

Show comment
Hide comment
@pushrax

pushrax Dec 24, 2014

Just pushed up 0.0.3, feel free to try it out.

pushrax commented Dec 24, 2014

Just pushed up 0.0.3, feel free to try it out.

@pushrax

This comment has been minimized.

Show comment
Hide comment
@pushrax

pushrax Dec 26, 2014

Ah, liquid-c is Ruby 2+

pushrax commented Dec 26, 2014

Ah, liquid-c is Ruby 2+

parkr added a commit that referenced this pull request Dec 27, 2014

@parkr parkr merged commit 3830956 into master Dec 27, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the liquid-3 branch Dec 27, 2014

parkr added a commit that referenced this pull request Dec 27, 2014

@parkr parkr referenced this pull request Jan 18, 2015

Closed

3.0 RELEASE GAMEPLAN #3324

7 of 7 tasks complete

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.