New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy Indexing with WEBrick. #3018

Merged
merged 3 commits into from Oct 21, 2014

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Oct 21, 2014

just read every line of the webrick code, which was both cool and terrible at the same time.

screen shot 2014-10-20 at 9 15 01 pm

a cleaner version of #2894.

@parkr parkr merged commit 3285aeb into master Oct 21, 2014

1 check was pending

continuous-integration/travis-ci The Travis CI build is in progress
Details

@parkr parkr deleted the webrick-fancy-indexing branch Oct 21, 2014

@parkr parkr added this to the 2.4.1 milestone Oct 21, 2014

parkr added a commit that referenced this pull request Oct 21, 2014

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Oct 21, 2014

Member

Nice work, sir 👏

Member

pathawks commented Oct 21, 2014

Nice work, sir 👏

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Oct 21, 2014

Member

Thanks! It was the easiest fix once I realized that WEBrick options != FileHandler options. 😆

Member

parkr commented Oct 21, 2014

Thanks! It was the easiest fix once I realized that WEBrick options != FileHandler options. 😆

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.