Add development time dependencies on minitest and test-unit to gemspec #3064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather conditionally add these based on the OS.
Is there documentation around this? |
|
I don't know if you can really call it Ruby without those being bundled. |
In the Cygwin environment, minitest and test-unit aren't bundled with Ruby. Add these as explicit development dependencies when running under Cygwin.
|
I've updated the commit to conditionally add them just for the Cygwin environment.
Not definitively (that I've been able to find at least) - Cygwin has separate packages with |
|
LGTM. |
parkr
added a commit
that referenced
this pull request
Nov 6, 2014
parkr
added a commit
that referenced
this pull request
Nov 6, 2014
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Cygwin environment, the
minitestandtest-unitgems aren't bundled with Ruby so abundle exec rake installfails.The commit in this PR adds these as development dependencies so that bundler can install them if they are missing.