Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development time dependencies on minitest and test-unit to gemspec #3064

Merged
merged 1 commit into from Nov 6, 2014

Conversation

Projects
None yet
4 participants
@ribbons
Copy link
Contributor

commented Nov 5, 2014

In the Cygwin environment, the minitest and test-unit gems aren't bundled with Ruby so a bundle exec rake install fails.

The commit in this PR adds these as development dependencies so that bundler can install them if they are missing.

@parkr

This comment has been minimized.

Copy link
Member

commented Nov 5, 2014

I'd rather conditionally add these based on the OS.

In the Cygwin environment, the minitest and test-unit gems aren't bundled with Ruby

Is there documentation around this?

@mattr-

This comment has been minimized.

Copy link
Member

commented Nov 5, 2014

I don't know if you can really call it Ruby without those being bundled.
👍 to adding them conditionally based on OS

Add development dependencies for Cygwin
In the Cygwin environment, minitest and test-unit aren't bundled with
Ruby.  Add these as explicit development dependencies when running under
Cygwin.
@ribbons

This comment has been minimized.

Copy link
Contributor Author

commented Nov 6, 2014

I've updated the commit to conditionally add them just for the Cygwin environment.

Is there documentation around this?

Not definitively (that I've been able to find at least) - Cygwin has separate packages with minitest and test-unitwhich aren't installed as dependencies of ruby. I've also found that other users have had similar issues: http://stackoverflow.com/questions/12501067/cant-make-the-rails-console-run-on-cygwin

@mattr-

This comment has been minimized.

Copy link
Member

commented Nov 6, 2014

LGTM. :shipit:

parkr added a commit that referenced this pull request Nov 6, 2014

@parkr parkr merged commit 7428934 into jekyll:master Nov 6, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Nov 6, 2014

@ribbons ribbons deleted the ribbons:cygwin-env branch Nov 9, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.