use built in travis caching #3075

Merged
merged 1 commit into from Nov 9, 2014

Conversation

Projects
None yet
4 participants
@joshk
Contributor

joshk commented Nov 8, 2014

also run bundle update to make sure the cache is not too old

use built in travis caching
also run bundle update to make sure the cache is not too old
@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Nov 8, 2014

Contributor

We only upload a cache on branch builds, so you won't see the speed difference our caching gives you until this is merged in

Contributor

joshk commented Nov 8, 2014

We only upload a cache on branch builds, so you won't see the speed difference our caching gives you until this is merged in

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 8, 2014

Member

Cool, thanks! So the bundle update call will mitigate issues with Gemfile.lock not existing in the repo? Also, what are the mechanics of this cache? What happens if an installed gem gets borked? Is it available on every single build? Is it magically there or is it pulled it magically?

Seems to have slowed down the unit tests by about 30 seconds :(

Member

parkr commented Nov 8, 2014

Cool, thanks! So the bundle update call will mitigate issues with Gemfile.lock not existing in the repo? Also, what are the mechanics of this cache? What happens if an installed gem gets borked? Is it available on every single build? Is it magically there or is it pulled it magically?

Seems to have slowed down the unit tests by about 30 seconds :(

@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Nov 8, 2014

Contributor

The bundle update will make sure you cache is always up to date with the latest gems.

Can you explain further by what you mean of a borked installed gem? The cache is a simple tar gz of all the gem downloaded. We also clean away unused Gems at the end of the job.

Don't worry about the slow down, the cache isn't being used yet.

Contributor

joshk commented Nov 8, 2014

The bundle update will make sure you cache is always up to date with the latest gems.

Can you explain further by what you mean of a borked installed gem? The cache is a simple tar gz of all the gem downloaded. We also clean away unused Gems at the end of the job.

Don't worry about the slow down, the cache isn't being used yet.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 8, 2014

Member

Can you explain further by what you mean of a borked installed gem? The cache is a simple tar gz of all the gem downloaded. We also clean away unused Gems at the end of the job.

It'd be if there were a problem installing the gem – but if Travis is just storing vendor/cache then all should be 👍

Don't worry about the slow down, the cache isn't being used yet.

Oh, ok. I'll merge this when it's ready! :)

Member

parkr commented Nov 8, 2014

Can you explain further by what you mean of a borked installed gem? The cache is a simple tar gz of all the gem downloaded. We also clean away unused Gems at the end of the job.

It'd be if there were a problem installing the gem – but if Travis is just storing vendor/cache then all should be 👍

Don't worry about the slow down, the cache isn't being used yet.

Oh, ok. I'll merge this when it's ready! :)

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Nov 8, 2014

Member

👍
@joshk Just wondering: is the bundle cache be available for PR's as well?

Member

alfredxing commented Nov 8, 2014

👍
@joshk Just wondering: is the bundle cache be available for PR's as well?

@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Nov 9, 2014

Contributor

@parkr use it now. We are just fixing a bug with caching, but it's ready for use right now.

@alfredxing yes, but a new cache is only uploaded during branch builds.

Contributor

joshk commented Nov 9, 2014

@parkr use it now. We are just fixing a bug with caching, but it's ready for use right now.

@alfredxing yes, but a new cache is only uploaded during branch builds.

parkr added a commit that referenced this pull request Nov 9, 2014

@parkr parkr merged commit 58180b1 into jekyll:master Nov 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Nov 9, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 9, 2014

Member

@parkr use it now. We are just fixing a bug with caching, but it's ready for use right now.

Great! Merged. Thanks for this! Ideally, the cache would be used on every single build (including pull requests). That is what would make using this better than anything else (short of a public S3 bucket). I'd love for our contributors to have the same wait time that we have – not a longer one. What do you think? Is it technically challenging?

Member

parkr commented Nov 9, 2014

@parkr use it now. We are just fixing a bug with caching, but it's ready for use right now.

Great! Merged. Thanks for this! Ideally, the cache would be used on every single build (including pull requests). That is what would make using this better than anything else (short of a public S3 bucket). I'd love for our contributors to have the same wait time that we have – not a longer one. What do you think? Is it technically challenging?

@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Nov 9, 2014

Contributor

As said just before, the cache is used for PRs, but we don't upload new caches per PR as there are potential security attack vectors.

Contributor

joshk commented Nov 9, 2014

As said just before, the cache is used for PRs, but we don't upload new caches per PR as there are potential security attack vectors.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 9, 2014

Member

Whoops, missed that. Thanks for the hard work, @joshk, and thanks for the PR to Jekyll!

Member

parkr commented Nov 9, 2014

Whoops, missed that. Thanks for the hard work, @joshk, and thanks for the PR to Jekyll!

@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Nov 9, 2014

Contributor

My pleasure, you guys keep rocking! High 5!


Sent from Mailbox

On Sun, Nov 9, 2014 at 7:01 PM, Parker Moore notifications@github.com
wrote:

Whoops, missed that. Thanks for the hard work, @joshk, and thanks for the PR to Jekyll!

Reply to this email directly or view it on GitHub:
#3075 (comment)

Contributor

joshk commented Nov 9, 2014

My pleasure, you guys keep rocking! High 5!


Sent from Mailbox

On Sun, Nov 9, 2014 at 7:01 PM, Parker Moore notifications@github.com
wrote:

Whoops, missed that. Thanks for the hard work, @joshk, and thanks for the PR to Jekyll!

Reply to this email directly or view it on GitHub:
#3075 (comment)

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Nov 9, 2014

Member

@joshk Thanks! Just checked a few of the recent CI builds (after this PR was merged), and it doesn't seem to be finding the cached bundle even though the uploading doesn't seem to fail... Any ideas?

Example: https://travis-ci.org/jekyll/jekyll/jobs/40443431

Member

alfredxing commented Nov 9, 2014

@joshk Thanks! Just checked a few of the recent CI builds (after this PR was merged), and it doesn't seem to be finding the cached bundle even though the uploading doesn't seem to fail... Any ideas?

Example: https://travis-ci.org/jekyll/jekyll/jobs/40443431

@parkr

This comment has been minimized.

Show comment
Hide comment
Member

parkr commented Nov 9, 2014

@joshk

This comment has been minimized.

Show comment
Hide comment
@joshk

joshk Nov 9, 2014

Contributor

As said in a previous message, we are fixing a small bug with caching, should be all fixed next week. 

Goodness will arrive soon.

On Sun, Nov 9, 2014 at 7:33 PM, Parker Moore notifications@github.com
wrote:

Seeing the same results: https://travis-ci.org/jekyll/jekyll/jobs/40443431#L19

Reply to this email directly or view it on GitHub:
#3075 (comment)

Contributor

joshk commented Nov 9, 2014

As said in a previous message, we are fixing a small bug with caching, should be all fixed next week. 

Goodness will arrive soon.

On Sun, Nov 9, 2014 at 7:33 PM, Parker Moore notifications@github.com
wrote:

Seeing the same results: https://travis-ci.org/jekyll/jekyll/jobs/40443431#L19

Reply to this email directly or view it on GitHub:
#3075 (comment)

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Nov 9, 2014

Member

Sounds good! Thanks again 👏

Member

alfredxing commented Nov 9, 2014

Sounds good! Thanks again 👏

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.