New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate 'Conversion error:' message #3088

Merged
merged 1 commit into from Nov 10, 2014

Conversation

Projects
None yet
3 participants
@alfredxing
Member

alfredxing commented Nov 10, 2014

Get rid of duplicate 'Conversion error:' prefix (I found this a bit confusing: are they separate errors?), instead opting for just the error text on a new line with the previous line pointing to it.

Before:

Conversion error: Jekyll::Converters::Scss encountered an error converting 'assets/css/main.scss'.
Conversion error: Invalid CSS after "... text-overflow": expected ";", was ": ellipsis;"

After:

Conversion error: Jekyll::Converters::Scss encountered an error while converting 'assets/css/main.scss':
                  Invalid CSS after "... text-overflow": expected ";", was ": ellipsis;"
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 10, 2014

Member

LGTM! 😄

Member

parkr commented Nov 10, 2014

LGTM! 😄

@parkr parkr merged commit 20f0940 into jekyll:master Nov 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Nov 10, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 10, 2014

Member

Does Renderer have the same problem?

Member

parkr commented Nov 10, 2014

Does Renderer have the same problem?

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Nov 10, 2014

Member

No, it doesn't have the second line.

Member

alfredxing commented Nov 10, 2014

No, it doesn't have the second line.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 10, 2014

Member

Ok. Maybe it should?

Member

parkr commented Nov 10, 2014

Ok. Maybe it should?

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Nov 10, 2014

Member

Added! (#3090)

Member

alfredxing commented Nov 10, 2014

Added! (#3090)

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.