Change variables of Google Analytics script #3093

Merged
merged 1 commit into from Nov 12, 2014

Conversation

Projects
None yet
6 participants
@shinnn
Contributor

shinnn commented Nov 11, 2014

i s o g r a m -> j e k y l L

Change variables of Google Analytics script
`i` `s` `o` `g` `r` `a` `m` -> `j` `e` `k` `y` `l` `L`

Generated by isogram
https://github.com/shinnn/isogram
@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Nov 11, 2014

Member

😀

Member

pathawks commented Nov 11, 2014

😀

@kleinfreund

This comment has been minimized.

Show comment
Hide comment
@kleinfreund

kleinfreund Nov 11, 2014

Contributor

Way better! ⚡️

Contributor

kleinfreund commented Nov 11, 2014

Way better! ⚡️

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 11, 2014

Member

I think we're using Gauges, not GA... but this is cool!

Member

parkr commented Nov 11, 2014

I think we're using Gauges, not GA... but this is cool!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 11, 2014

Member

Would be even cooler if it were j e k y ll r b. Aren't there 7 letters, too?

Member

parkr commented Nov 11, 2014

Would be even cooler if it were j e k y ll r b. Aren't there 7 letters, too?

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Nov 11, 2014

Member

@parkr One of the things passed in was just a constant URL, I think the one using 6 letters just hard-coded that in to the function. It seems like the site is using both Gauges and GA right now.

Member

alfredxing commented Nov 11, 2014

@parkr One of the things passed in was just a constant URL, I think the one using 6 letters just hard-coded that in to the function. It seems like the site is using both Gauges and GA right now.

@shinnn

This comment has been minimized.

Show comment
Hide comment
@shinnn

shinnn Nov 11, 2014

Contributor

I'm glad you like it :)

This code is generated by isogram.
Currently it supports 5, 6, and 7 parameter version.

Aren't there 7 letters, too?

Both 6-parameter version and 7-parameter version passes the test.
https://travis-ci.org/shinnn/isogram/jobs/36501332#L232

One of the things passed in was just a constant URL, I think the one using 6 letters just hard-coded that in to the function.

Yes, @alfredxing is right.

Contributor

shinnn commented Nov 11, 2014

I'm glad you like it :)

This code is generated by isogram.
Currently it supports 5, 6, and 7 parameter version.

Aren't there 7 letters, too?

Both 6-parameter version and 7-parameter version passes the test.
https://travis-ci.org/shinnn/isogram/jobs/36501332#L232

One of the things passed in was just a constant URL, I think the one using 6 letters just hard-coded that in to the function.

Yes, @alfredxing is right.

parkr added a commit that referenced this pull request Nov 12, 2014

@parkr parkr merged commit a48379a into jekyll:master Nov 12, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Nov 12, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 12, 2014

Member

Deployed! Thanks :)

Member

parkr commented Nov 12, 2014

Deployed! Thanks :)

@shinnn shinnn deleted the shinnn:ga branch Nov 12, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.