New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle require for :jekyll_plugins #3119

Merged
merged 3 commits into from Nov 22, 2014

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Nov 17, 2014

Per conversation here: bundler/bundler#3252 (comment)

@parkr parkr added this to the 2.5.2 milestone Nov 17, 2014

@@ -33,11 +33,12 @@ def require_gems
end
def self.require_from_bundler
if ENV["JEKYLL_NO_BUNDLER_REQUIRE"]
if ENV["JEKYLL_NO_BUNDLER_REQUIRE"] || !File.file?("Gemfile")

This comment has been minimized.

@mattr-

mattr- Nov 18, 2014

Member

Do we need to care that it's a file or only that it exists and let Bundler do the thing if the Gemfile is invalid?

@mattr-

mattr- Nov 18, 2014

Member

Do we need to care that it's a file or only that it exists and let Bundler do the thing if the Gemfile is invalid?

This comment has been minimized.

@parkr

parkr Nov 18, 2014

Member

I guess I don't want Bundler in the runtime if there's no Gemfile.

@parkr

parkr Nov 18, 2014

Member

I guess I don't want Bundler in the runtime if there's no Gemfile.

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Nov 18, 2014

Member

LGTM. :shipit:

Member

mattr- commented Nov 18, 2014

LGTM. :shipit:

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 22, 2014

Member

Failures due to RedCarpet 😡 . Will merge.

Member

parkr commented Nov 22, 2014

Failures due to RedCarpet 😡 . Will merge.

@parkr parkr merged commit 9a94829 into master Nov 22, 2014

1 check failed

continuous-integration/travis-ci The Travis CI build failed
Details

@parkr parkr deleted the fix-bundle-require branch Nov 22, 2014

parkr added a commit that referenced this pull request Nov 22, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.