New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs site sass improvements #3123

Merged
merged 2 commits into from Nov 17, 2014

Conversation

Projects
None yet
4 participants
@jglovier
Member

jglovier commented Nov 17, 2014

When the site was converted to Sass in #2651, the new sass files didn't take full advantage of Sass selector nesting, which makes editing Sass files a smoother experience. This pull refactors the SCSS to take advantage of selector nesting, and removes some commented out rules.

@troyswanson

This comment has been minimized.

Show comment
Hide comment
@troyswanson

troyswanson Nov 17, 2014

Member

Nicely done! This looks good from where I'm sitting, but there's quite a bit of movement in this code so if something is misplaced, I probably missed it. Definitely a step up from what we have right now though.

Thanks 👍

Member

troyswanson commented Nov 17, 2014

Nicely done! This looks good from where I'm sitting, but there's quite a bit of movement in this code so if something is misplaced, I probably missed it. Definitely a step up from what we have right now though.

Thanks 👍

@jglovier

This comment has been minimized.

Show comment
Hide comment
@jglovier

jglovier Nov 17, 2014

Member

🤘

Member

jglovier commented Nov 17, 2014

🤘

@parkr parkr merged commit 5185c8d into master Nov 17, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the site-sass-improvements branch Nov 17, 2014

parkr added a commit that referenced this pull request Nov 17, 2014

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Nov 17, 2014

Member

Looks amazing. Up on GHP now!

Member

parkr commented Nov 17, 2014

Looks amazing. Up on GHP now!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.