New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken markdown file extension regexp #3147

Merged
merged 2 commits into from Nov 25, 2014

Conversation

Projects
None yet
5 participants
@blbradley
Contributor

blbradley commented Nov 25, 2014

Hello!

On the last edition of the the regexp that matches markdown file extensions, the part that matches the beginning of the file extension of removed. I was setting up a site with some Rmarkdown files, and .Rmd files were being processed as regular markdown files. Patched!

I specifically used .Rmd in the test. I hope that is ok! I used this fix with an Rmarkdown converter, and it worked fine (but out of scope of this PR).

Cheers!

@blbradley

This comment has been minimized.

Contributor

blbradley commented Nov 25, 2014

This is a regression of #1382.

@blbradley blbradley changed the title from Broken markdown file extension regexp (regression of #1382) to Broken markdown file extension regexp Nov 25, 2014

@yihui

This comment has been minimized.

yihui commented Nov 25, 2014

👍

@parkr

This comment has been minimized.

Member

parkr commented Nov 25, 2014

This looks really solid. Thanks for the patch, @blbradley!

@parkr parkr added the fix label Nov 25, 2014

@parkr parkr added this to the 2.5.3 milestone Nov 25, 2014

@parkr parkr self-assigned this Nov 25, 2014

@parkr

This comment has been minimized.

Member

parkr commented Nov 25, 2014

@alfredxing, What do you think?

@alfredxing

This comment has been minimized.

Member

alfredxing commented Nov 25, 2014

Looks good to me! This was most likely a copying issue on 4942b29, anyway.

@blbradley

This comment has been minimized.

Contributor

blbradley commented Nov 25, 2014

@alfredxing I thought it looked like a copying issue as well. New test should cover that.

parkr added a commit that referenced this pull request Nov 25, 2014

@parkr parkr merged commit 37af23b into jekyll:master Nov 25, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Nov 25, 2014

@parkr

This comment has been minimized.

Member

parkr commented Nov 25, 2014

😄

parkr added a commit that referenced this pull request Dec 8, 2014

yihui added a commit to yihui/blogdown-jekyll that referenced this pull request Dec 31, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.