New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified platform detection for Windows #3177

Merged
merged 1 commit into from Dec 1, 2014

Conversation

Projects
None yet
4 participants
@rpherbig
Contributor

rpherbig commented Dec 1, 2014

No description provided.

@rpherbig

This comment has been minimized.

Show comment
Hide comment
@rpherbig

rpherbig Dec 1, 2014

Contributor

I'm referencing https://www.omniref.com/ruby/2.1.2/symbols/Gem/win_platform%3F/singleton (and, anecdotally, it works on my machine).

Contributor

rpherbig commented on 3b57879 Dec 1, 2014

I'm referencing https://www.omniref.com/ruby/2.1.2/symbols/Gem/win_platform%3F/singleton (and, anecdotally, it works on my machine).

@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Dec 1, 2014

Member

Looks good to me. Gem.win_platform? goes back all the way to 1.9.3 :shipit:

Member

mattr- commented Dec 1, 2014

Looks good to me. Gem.win_platform? goes back all the way to 1.9.3 :shipit:

parkr added a commit that referenced this pull request Dec 1, 2014

@parkr parkr merged commit 7c8c41f into jekyll:master Dec 1, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Dec 1, 2014

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.