New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the default host on docs #3229

Merged
merged 1 commit into from Dec 23, 2014

Conversation

Projects
None yet
4 participants
@megalomono
Contributor

megalomono commented Dec 23, 2014

It seems that the default host for Jekyll server was changed on jekyll/jekyll/pull/3053. Nevertheless, the documentation specifies the default host as 0.0.0.0.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Dec 23, 2014

Contributor

Or you could change the docs...

Contributor

XhmikosR commented Dec 23, 2014

Or you could change the docs...

@megalomono

This comment has been minimized.

Show comment
Hide comment
@megalomono

megalomono Dec 23, 2014

Contributor

Sorry, I didn't explained myself clearly. What I meant was that I have already changed the default host on the configuration page. Then I made the pull request at the master branch as stated at the contributing section on the site. Did I proceed correctly? Did I miss some step?

Contributor

megalomono commented Dec 23, 2014

Sorry, I didn't explained myself clearly. What I meant was that I have already changed the default host on the configuration page. Then I made the pull request at the master branch as stated at the contributing section on the site. Did I proceed correctly? Did I miss some step?

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Dec 23, 2014

Contributor

Well, you basically revert #3053. I'm not sure this is intended.

/CC @parkr

Contributor

XhmikosR commented Dec 23, 2014

Well, you basically revert #3053. I'm not sure this is intended.

/CC @parkr

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Dec 23, 2014

Member

👍

Member

parkr commented Dec 23, 2014

👍

@megalomono

This comment has been minimized.

Show comment
Hide comment
@megalomono

megalomono Dec 23, 2014

Contributor

Sorry but I don't understand what you mean. What I have done is update the info on site/_docs/configuration.md in order to make it match with the changes in #3053.

Contributor

megalomono commented Dec 23, 2014

Sorry but I don't understand what you mean. What I have done is update the info on site/_docs/configuration.md in order to make it match with the changes in #3053.

parkr added a commit that referenced this pull request Dec 23, 2014

@parkr parkr merged commit 0fcba08 into jekyll:master Dec 23, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Dec 23, 2014

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Dec 23, 2014

Contributor

You did well. I misread and thought you did the opposite.
On Dec 23, 2014 11:49 PM, "Fonso" notifications@github.com wrote:

Sorry but I don't understand what you mean. What I have done is update the
info on site/_docs/configuration.md in order to make it match with the
changes in #3053 #3053.


Reply to this email directly or view it on GitHub
#3229 (comment).

Contributor

XhmikosR commented Dec 23, 2014

You did well. I misread and thought you did the opposite.
On Dec 23, 2014 11:49 PM, "Fonso" notifications@github.com wrote:

Sorry but I don't understand what you mean. What I have done is update the
info on site/_docs/configuration.md in order to make it match with the
changes in #3053 #3053.


Reply to this email directly or view it on GitHub
#3229 (comment).

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.