Docs: Assorted accessibility tweaks. #3256

Merged
merged 1 commit into from Jan 10, 2015

Conversation

Projects
None yet
4 participants
@XhmikosR
Contributor

XhmikosR commented Jan 4, 2015

jekkylrb.com:
jekyllrb-com

this branch:
access-branch

@XhmikosR XhmikosR changed the title from Assorted accessibility tweaks. to Docs: Assorted accessibility tweaks. Jan 4, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 5, 2015

Member

I'm pretty happy with this. Not super excited about the darker background color for the footer and the code block but I'm open to it.

@cobyism Any thoughts here?

Member

parkr commented Jan 5, 2015

I'm pretty happy with this. Not super excited about the darker background color for the footer and the code block but I'm open to it.

@cobyism Any thoughts here?

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
Contributor

XhmikosR commented Jan 5, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 5, 2015

Member

That's a cool tool! I'll have to look up why the contrast ratio is expected at that particular level.

Member

parkr commented Jan 5, 2015

That's a cool tool! I'll have to look up why the contrast ratio is expected at that particular level.

@cobyism

This comment has been minimized.

Show comment
Hide comment
@cobyism

cobyism Jan 5, 2015

Member

This all seems fine to me. I think the darker background for the terminal window is a good move, however I’m not sure the other colour changes are really that much of a win. I don’t have any problems with them though, so 👍

Member

cobyism commented Jan 5, 2015

This all seems fine to me. I think the darker background for the terminal window is a good move, however I’m not sure the other colour changes are really that much of a win. I don’t have any problems with them though, so 👍

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 5, 2015

Contributor

In case it's not clear, I tried to bump the colors enough so that they pass WCAG2AA, nothing more :)

As for the empty span, personally I'd rather add a new sr-only class and make use of it everywhere for the screen readers. Let me know if you agree with that and I'll make the change adapting the class from Bootstrap.

Contributor

XhmikosR commented Jan 5, 2015

In case it's not clear, I tried to bump the colors enough so that they pass WCAG2AA, nothing more :)

As for the empty span, personally I'd rather add a new sr-only class and make use of it everywhere for the screen readers. Let me know if you agree with that and I'll make the change adapting the class from Bootstrap.

@cobyism

This comment has been minimized.

Show comment
Hide comment
@cobyism

cobyism Jan 5, 2015

Member

I'd rather add a new sr-only class and make use of it everywhere for the screen readers.

Sounds good, yeah. Would another option be to add a title attribute or something similar to the icon element?

Member

cobyism commented Jan 5, 2015

I'd rather add a new sr-only class and make use of it everywhere for the screen readers.

Sounds good, yeah. Would another option be to add a title attribute or something similar to the icon element?

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 5, 2015

Contributor

Done. I added title="Permalink" in the a element too.

Contributor

XhmikosR commented Jan 5, 2015

Done. I added title="Permalink" in the a element too.

@parkr parkr merged commit f2650e7 into jekyll:master Jan 10, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jan 10, 2015

@XhmikosR XhmikosR deleted the XhmikosR:accessibility-tweaks branch Jan 10, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.