Symlink local tmp #3258

Merged
merged 2 commits into from Jan 10, 2015

Conversation

Projects
None yet
4 participants
@omegahm
Contributor

omegahm commented Jan 4, 2015

Fixes #2831 and possibly #2773

The two tests regarding symlinks will use tmp in the root-dir instead of /tmp.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 5, 2015

Member

Cool! We alread have a tmp directory so I'd rather use that. Kill the . and we're in business. Thanks!

Member

parkr commented Jan 5, 2015

Cool! We alread have a tmp directory so I'd rather use that. Kill the . and we're in business. Thanks!

@omegahm

This comment has been minimized.

Show comment
Hide comment
@omegahm

omegahm Jan 5, 2015

Contributor

@parkr I think we might need to have the tmp folder in Git with a .keep file. What's your take on that?

Contributor

omegahm commented Jan 5, 2015

@parkr I think we might need to have the tmp folder in Git with a .keep file. What's your take on that?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 5, 2015

Member

@parkr I think we might need to have the tmp folder in Git with a .keep file. What's your take on that?

I'd rather the script/test create the tmp directory than track it through Git.

Member

parkr commented Jan 5, 2015

@parkr I think we might need to have the tmp folder in Git with a .keep file. What's your take on that?

I'd rather the script/test create the tmp directory than track it through Git.

@omegahm

This comment has been minimized.

Show comment
Hide comment
@omegahm

omegahm Jan 5, 2015

Contributor

@parkr Yup, I can see that that is actually also what is failing on Travis. 😵

I have added mkdir tmp to script/test.

Contributor

omegahm commented Jan 5, 2015

@parkr Yup, I can see that that is actually also what is failing on Travis. 😵

I have added mkdir tmp to script/test.

@XhmikosR

This comment has been minimized.

Show comment
Hide comment
@XhmikosR

XhmikosR Jan 5, 2015

Contributor

This will fix 2 of the failing tests on Windows too hopefully.

Contributor

XhmikosR commented Jan 5, 2015

This will fix 2 of the failing tests on Windows too hopefully.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 5, 2015

Member

Great work. :shipit:

Member

parkr commented Jan 5, 2015

Great work. :shipit:

@parkr parkr merged commit 0bf82e9 into jekyll:master Jan 10, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jan 10, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.