Fix nav items alignment when on multiple rows #3264

Merged
merged 1 commit into from Jan 7, 2015

Conversation

Projects
None yet
4 participants
@tkrotoff
Contributor

tkrotoff commented Jan 7, 2015

With the default theme, when you have multiple pages and thus "nav items", they span over multiple rows.
Problem: the nav items are misaligned

margin-left

Solution: use margin-right instead of margin-left

margin-right

@kleinfreund

This comment has been minimized.

Show comment
Hide comment
@kleinfreund

kleinfreund Jan 7, 2015

Contributor

👍

Contributor

kleinfreund commented Jan 7, 2015

👍

@tkrotoff

This comment has been minimized.

Show comment
Hide comment
@tkrotoff

tkrotoff Jan 7, 2015

Contributor

Question: is there a way to test the default template/theme using my local Jekyll git repo?
For this pull request I have manually tested by performing a jekyll new test1 & cd test1 & jekyll s which is a bit cumbersome

Contributor

tkrotoff commented Jan 7, 2015

Question: is there a way to test the default template/theme using my local Jekyll git repo?
For this pull request I have manually tested by performing a jekyll new test1 & cd test1 & jekyll s which is a bit cumbersome

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 7, 2015

Member

👍

Member

parkr commented Jan 7, 2015

👍

@parkr parkr merged commit 2f4e5fa into jekyll:master Jan 7, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jan 7, 2015

@tkrotoff

This comment has been minimized.

Show comment
Hide comment
@tkrotoff

tkrotoff Jan 19, 2015

Contributor

Ooops I have introduced a bug with this commit when the menu is in "burger" mode:

"burger" mode bug

See pull request #3329 for the fix

Contributor

tkrotoff commented Jan 19, 2015

Ooops I have introduced a bug with this commit when the menu is in "burger" mode:

"burger" mode bug

See pull request #3329 for the fix

tkrotoff added a commit to tkrotoff/osteo15.com that referenced this pull request Feb 16, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.