Change collection documentation based on #223 #3271

Merged
merged 1 commit into from Jan 10, 2015

Conversation

Projects
None yet
4 participants
@maban
Contributor

maban commented Jan 8, 2015

Clarifying what happens if no YAML front matter exists. The current explanation says that Jekyll will generate a file without Front Matter, but it appears this isn't the case.

I'm still not sure if this is the intended behaviour, but this clarifies how it currently works.

Change collection documentation based on #223
Clarifying what happens if no YAML front matter exists. The current explanation says that Jekyll will generate a file without Front Matter, but it appears this isn't the case.

I'm still not sure if this is the intended behaviour, but this clarifies how it currently works.
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 8, 2015

Member

Seems like the documentation described intended behavior.

Member

parkr commented Jan 8, 2015

Seems like the documentation described intended behavior.

@kleinfreund

This comment has been minimized.

Show comment
Hide comment
@kleinfreund

kleinfreund Jan 8, 2015

Contributor

@parkr The bit that files need front matter to be generated into the collection is one that can be easily missed, I think. The proposed change would clarify that.

Contributor

kleinfreund commented Jan 8, 2015

@parkr The bit that files need front matter to be generated into the collection is one that can be easily missed, I think. The proposed change would clarify that.

@maban

This comment has been minimized.

Show comment
Hide comment
@maban

maban Jan 9, 2015

Contributor

@parkr If that's the intended behaviour, it's not currently working. That's why I'm recommending changing the documentation to explain how it currently works. I'd love it if Jekyll did generate files without Front Matter, and if it's meant to, a change to the documentation until a codebase change is pushed would really help. (I spent quite a few hours over Christmas trying to figure out why my site wasn't building properly based on what the documentation said.)

Contributor

maban commented Jan 9, 2015

@parkr If that's the intended behaviour, it's not currently working. That's why I'm recommending changing the documentation to explain how it currently works. I'd love it if Jekyll did generate files without Front Matter, and if it's meant to, a change to the documentation until a codebase change is pushed would really help. (I spent quite a few hours over Christmas trying to figure out why my site wasn't building properly based on what the documentation said.)

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 10, 2015

Member

I think the implications are around binary static files.

Member

parkr commented Jan 10, 2015

I think the implications are around binary static files.

parkr added a commit that referenced this pull request Jan 10, 2015

@parkr parkr merged commit 5536f95 into jekyll:master Jan 10, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 10, 2015

Member

Let's fix the documentation for now and fix the code later.

Member

parkr commented Jan 10, 2015

Let's fix the documentation for now and fix the code later.

parkr added a commit that referenced this pull request Jan 10, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.