Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Eliminate the need for prev_section and next_section metadata. #3292
Not sure if we want this code...
This PR started with me looking into how we do all this awesome documentation/collection stuff, and then I saw that we keep track of nav metadata in two places, the yaml file and in the document as metadata, and that made me really sad. I also hadn't ever done work with liquid - it's kinda cool, but kinda gross [the creation of the doc list makes me sad]. Regardless, here we are, and believe it or not this code doesn't seem to increase build time all that much.
Got to thinking about chained filters and low and behold, I could dry up some code :)
With out change:
With latest (b31d8a1) change:
It makes me sad that iterations are so expensive. That said though, I feel like trading some time for possible human error is worth it - but I might also be biased.