Eliminate the need for prev_section and next_section metadata. #3292
Conversation
| {% endcomment %} | ||
|
|
||
| {% for document in document_array %} | ||
| {% assign document_url = document | prepend:"/docs/" | append:"/" %} |
There was a problem hiding this comment.
It would be cool if you could do site.docs | where: "url",document or something.
|
Not bad. Lots of fancy Liquid going on there, but looks pretty solid. How does this impact build performance? |
|
@flyinprogrammer Wonderful to see someone focusing on such aspects. At the time, the metadata-driven navigation was an improvement; prior-- it was static. 🔢 I look forward to exploring your concepts. I am also curious about the differential in build times. |
|
Got to thinking about chained filters and low and behold, I could dry up some code :) With out change: With latest (b31d8a1) change: It makes me sad that iterations are so expensive. That said though, I feel like trading some time for possible human error is worth it - but I might also be biased. 😉 |
|
Worth it. Thanks! |
|
Awesome job. I've been wanting to do this since 7f3b351 (exactly one year ago!) but couldn't figure out how to do it. Your solution is exactly what I should have come up with. Thanks 👍 |
Not sure if we want this code...
This PR started with me looking into how we do all this awesome documentation/collection stuff, and then I saw that we keep track of nav metadata in two places, the yaml file and in the document as metadata, and that made me really sad. I also hadn't ever done work with liquid - it's kinda cool, but kinda gross [the creation of the doc list makes me sad]. Regardless, here we are, and believe it or not this code doesn't seem to increase build time all that much.