New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date method in filters.rb should accept a Date object #3299

Merged
merged 3 commits into from Jan 13, 2015

Conversation

Projects
None yet
4 participants
@ryanburnette
Contributor

ryanburnette commented Jan 13, 2015

As uncovered in #3298, the date method in filters.rb should accept a Date object.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 13, 2015

Member

Can you please add a test? Also, does this require we require 'date'?

Member

parkr commented Jan 13, 2015

Can you please add a test? Also, does this require we require 'date'?

@ryanburnette

This comment has been minimized.

Show comment
Hide comment
@ryanburnette

ryanburnette Jan 13, 2015

Contributor

Tests written. I should have done that first.

It was working before, but I figured it couldn't hurt to add require 'date'. I put it at the top of filters.rb, was that the right location?

Contributor

ryanburnette commented Jan 13, 2015

Tests written. I should have done that first.

It was working before, but I figured it couldn't hurt to add require 'date'. I put it at the top of filters.rb, was that the right location?

@troyswanson

This comment has been minimized.

Show comment
Hide comment
@troyswanson

troyswanson Jan 13, 2015

Member

👏 Nice.

Member

troyswanson commented Jan 13, 2015

👏 Nice.

@parkr parkr referenced this pull request Jan 13, 2015

Closed

Jekyll i18n Error #3293

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 13, 2015

Member

I put it at the top of filters.rb, was that the right location?

We historically have put them in jekyll.rb, but I think this is perfect. Each file should hypothetically be individually-requirable.

Member

parkr commented Jan 13, 2015

I put it at the top of filters.rb, was that the right location?

We historically have put them in jekyll.rb, but I think this is perfect. Each file should hypothetically be individually-requirable.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 13, 2015

Member

Well done! Merging.

Member

parkr commented Jan 13, 2015

Well done! Merging.

parkr added a commit that referenced this pull request Jan 13, 2015

@parkr parkr merged commit 763118a into jekyll:master Jan 13, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

parkr added a commit that referenced this pull request Jan 13, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.