New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site-nav alignment on small screens #3331

Merged
merged 1 commit into from Jan 21, 2015

Conversation

Projects
None yet
4 participants
@tkrotoff
Contributor

tkrotoff commented Jan 21, 2015

Before:
30px

After:
$spacing-unit / 2

(Screenshots from iPhone 4s simulator)

Considering the site title is 15px away from the left screen border ($spacing-unit is 30px) on small screens:

.wrapper {
    @include media-query($on-laptop) {
        padding-right: $spacing-unit / 2;
        padding-left: $spacing-unit / 2;
    }
}

site-nav (the "burger" menu) should be 15px from the right screen border instead of the hardcoded value of 30px.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 21, 2015

Member

👍

Member

parkr commented Jan 21, 2015

👍

1 similar comment
@mattr-

This comment has been minimized.

Show comment
Hide comment
@mattr-

mattr- Jan 21, 2015

Member

👍

Member

mattr- commented Jan 21, 2015

👍

@mattr- mattr- merged commit c4255eb into jekyll:master Jan 21, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

mattr- added a commit that referenced this pull request Jan 21, 2015

@tkrotoff tkrotoff deleted the tkrotoff:fix-site-nav-alignment branch Jan 29, 2015

tkrotoff added a commit to tkrotoff/osteo15.com that referenced this pull request Feb 16, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.