New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out a `read_data_file` call to keep things clean #3380

Merged
merged 2 commits into from Jan 31, 2015

Conversation

Projects
None yet
4 participants
@gjtorikian
Member

gjtorikian commented Jan 29, 2015

I actually need this for a monkey-patch I am planning. 馃槈 But it does look cleaner, no?

/cc @parkr

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 29, 2015

Member

Looks good to me, but it needs a test. 馃槃

Member

parkr commented Jan 29, 2015

Looks good to me, but it needs a test. 馃槃

@gjtorikian

This comment has been minimized.

Show comment
Hide comment
@gjtorikian

gjtorikian Jan 29, 2015

Member

Hrm, I would think the fact that nothing broke would be a succeeding test? 馃槈 Ok, ok...

Member

gjtorikian commented Jan 29, 2015

Hrm, I would think the fact that nothing broke would be a succeeding test? 馃槈 Ok, ok...

@parkr parkr added the Enhancement label Jan 29, 2015

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Jan 30, 2015

Member

馃憤 Would also be great if we could allow custom data formats in the future in the form of plugins.

Member

alfredxing commented Jan 30, 2015

馃憤 Would also be great if we could allow custom data formats in the future in the form of plugins.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 30, 2015

Member

Would also be great if we could allow custom data formats in the future in the form of plugins.

We could also start using converters...

Member

parkr commented Jan 30, 2015

Would also be great if we could allow custom data formats in the future in the form of plugins.

We could also start using converters...

@parkr parkr merged commit 3bac8a2 into master Jan 31, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@parkr parkr deleted the gjtorikian-patch-1 branch Jan 31, 2015

parkr added a commit that referenced this pull request Jan 31, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.