Remove extra spaces #3388

Merged
merged 1 commit into from Jan 31, 2015

Conversation

Projects
None yet
5 participants
@chrisfinazzo
Contributor

chrisfinazzo commented Jan 31, 2015

No description provided.

@kleinfreund

This comment has been minimized.

Show comment
Hide comment
@kleinfreund

kleinfreund Jan 31, 2015

Contributor

👍

Contributor

kleinfreund commented Jan 31, 2015

👍

@chrisfinazzo

This comment has been minimized.

Show comment
Hide comment
@chrisfinazzo

chrisfinazzo Jan 31, 2015

Contributor

Good to see that this passed w/o a problem. However, I did notice errors while running rake. None of the tests explicitly failed, but I wonder if this is a known issue...

cc // @parkr @mattr @alfredxing

Contributor

chrisfinazzo commented Jan 31, 2015

Good to see that this passed w/o a problem. However, I did notice errors while running rake. None of the tests explicitly failed, but I wonder if this is a known issue...

cc // @parkr @mattr @alfredxing

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Jan 31, 2015

Member

@chrisfinazzo Can you paste in the errors that you got?

Member

alfredxing commented Jan 31, 2015

@chrisfinazzo Can you paste in the errors that you got?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 31, 2015

Member

@chrisfinazzo And what rake command you were using?

Member

parkr commented Jan 31, 2015

@chrisfinazzo And what rake command you were using?

@parkr parkr merged commit 922a92d into jekyll:master Jan 31, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 31, 2015

Member

These changes didn't cause any errors locally when running bundle exec rake site:preview.

Member

parkr commented Jan 31, 2015

These changes didn't cause any errors locally when running bundle exec rake site:preview.

parkr added a commit that referenced this pull request Jan 31, 2015

@chrisfinazzo

This comment has been minimized.

Show comment
Hide comment
@chrisfinazzo

chrisfinazzo Jan 31, 2015

Contributor

Using Rake 10.4.2 w/ rake test

[460/532] TestTags#test_: include tag with parameters with symlink'd inc        
  1) Error:
TestTags#test_: include tag with parameters with symlink'd include should not allow symlink includes. :
Errno::ENOENT: No such file or directory @ rb_sysopen - tmp/pages-test
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:351:in `initialize'
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:351:in `open'
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:351:in `block (3 levels) in '
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/shoulda-context-1.2.1/lib/shoulda/context/context.rb:413:in `instance_exec'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/shoulda-context-1.2.1/lib/shoulda/context/context.rb:413:in `block in create_test_from_should_hash'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1265:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit/testcase.rb:17:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:940:in `block in _run_suite'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:933:in `map'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:933:in `_run_suite'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:663:in `block in _run_suites'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:661:in `each'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:661:in `_run_suites'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:884:in `_run_anything'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1092:in `run_tests'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1079:in `block in _run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1078:in `each'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1078:in `_run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1066:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:27:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:780:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:372:in `block (2 levels) in autorun'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:33:in `run_once'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:371:in `block in autorun'
[480/532] TestTags#test_: relative include tag with variable and liquid         
  2) Error:
TestTags#test_: relative include tag with variable and liquid filters with symlink'd include should not allow symlink includes. :
Errno::ENOENT: No such file or directory @ rb_sysopen - tmp/pages-test
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:642:in `initialize'
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:642:in `open'
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:642:in `block (3 levels) in '
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/shoulda-context-1.2.1/lib/shoulda/context/context.rb:413:in `instance_exec'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/shoulda-context-1.2.1/lib/shoulda/context/context.rb:413:in `block in create_test_from_should_hash'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1265:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit/testcase.rb:17:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:940:in `block in _run_suite'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:933:in `map'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:933:in `_run_suite'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:663:in `block in _run_suites'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:661:in `each'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:661:in `_run_suites'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:884:in `_run_anything'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1092:in `run_tests'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1079:in `block in _run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1078:in `each'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1078:in `_run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1066:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:27:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:780:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:372:in `block (2 levels) in autorun'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:33:in `run_once'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:371:in `block in autorun'
Contributor

chrisfinazzo commented Jan 31, 2015

Using Rake 10.4.2 w/ rake test

[460/532] TestTags#test_: include tag with parameters with symlink'd inc        
  1) Error:
TestTags#test_: include tag with parameters with symlink'd include should not allow symlink includes. :
Errno::ENOENT: No such file or directory @ rb_sysopen - tmp/pages-test
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:351:in `initialize'
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:351:in `open'
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:351:in `block (3 levels) in '
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/shoulda-context-1.2.1/lib/shoulda/context/context.rb:413:in `instance_exec'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/shoulda-context-1.2.1/lib/shoulda/context/context.rb:413:in `block in create_test_from_should_hash'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1265:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit/testcase.rb:17:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:940:in `block in _run_suite'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:933:in `map'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:933:in `_run_suite'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:663:in `block in _run_suites'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:661:in `each'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:661:in `_run_suites'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:884:in `_run_anything'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1092:in `run_tests'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1079:in `block in _run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1078:in `each'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1078:in `_run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1066:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:27:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:780:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:372:in `block (2 levels) in autorun'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:33:in `run_once'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:371:in `block in autorun'
[480/532] TestTags#test_: relative include tag with variable and liquid         
  2) Error:
TestTags#test_: relative include tag with variable and liquid filters with symlink'd include should not allow symlink includes. :
Errno::ENOENT: No such file or directory @ rb_sysopen - tmp/pages-test
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:642:in `initialize'
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:642:in `open'
    /Users/Chris/Documents/Jekyll/test/test_tags.rb:642:in `block (3 levels) in '
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/shoulda-context-1.2.1/lib/shoulda/context/context.rb:413:in `instance_exec'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/gems/2.1.0/gems/shoulda-context-1.2.1/lib/shoulda/context/context.rb:413:in `block in create_test_from_should_hash'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1265:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit/testcase.rb:17:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:940:in `block in _run_suite'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:933:in `map'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:933:in `_run_suite'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:663:in `block in _run_suites'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:661:in `each'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:661:in `_run_suites'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:884:in `_run_anything'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1092:in `run_tests'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1079:in `block in _run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1078:in `each'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1078:in `_run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/minitest/unit.rb:1066:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:27:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:780:in `run'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:372:in `block (2 levels) in autorun'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:33:in `run_once'
    /Users/Chris/.rbenv/versions/2.1.0/lib/ruby/2.1.0/test/unit.rb:371:in `block in autorun'
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 31, 2015

Member

Ah, we don't mkdir -p tmp here...

Member

parkr commented Jan 31, 2015

Ah, we don't mkdir -p tmp here...

@chrisfinazzo chrisfinazzo deleted the chrisfinazzo:extra-spaces-are-for-animals branch Feb 1, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.