Show only two decimals in time to generate pages #3415

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@eksperimental
Contributor

eksperimental commented Feb 6, 2015

no need to display 10 decimals.
it fills up my screen with useless numbers! ;-p

Show only two decimals in time to generate pages
no need to display 10 decimals.
it feels up my screen with useless numbers! ;-p
lib/jekyll/commands/build.rb
@@ -57,7 +57,7 @@ def build(site, options)
Jekyll.logger.info "Incremental build:", (full_build ? "disabled" : "enabled")
Jekyll.logger.info "Generating..."
process_site(site)
- Jekyll.logger.info "", "done in #{Time.now - t} seconds."
+ Jekyll.logger.info "", "done in #{(Time.now - t).round 2} seconds."

This comment has been minimized.

@parkr

parkr Feb 6, 2015

Member

Is there a possible world which shows 0.00 seconds? Maybe 3?

Also, from a code-style standpoint, I'd prefer parentheses around the argument to #round 😄

@parkr

parkr Feb 6, 2015

Member

Is there a possible world which shows 0.00 seconds? Maybe 3?

Also, from a code-style standpoint, I'd prefer parentheses around the argument to #round 😄

This comment has been minimized.

@eksperimental

eksperimental Feb 6, 2015

Contributor

in the case of your possible world. then we need to use ceil(), so it will be 0.01 :-D

i thought no parenthesis was more aesthetic.
anyway.. fixed

@eksperimental

eksperimental Feb 6, 2015

Contributor

in the case of your possible world. then we need to use ceil(), so it will be 0.01 :-D

i thought no parenthesis was more aesthetic.
anyway.. fixed

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 6, 2015

Member

Wonderful!

Member

parkr commented Feb 6, 2015

Wonderful!

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Feb 6, 2015

Member

👍

Member

alfredxing commented Feb 6, 2015

👍

Update build.rb
parenthesis added to round
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 8, 2015

Member

Moved it to 3 decimal places in 66f2a50249c5e2ebd05bac77c823c98d549830c7

Member

parkr commented Feb 8, 2015

Moved it to 3 decimal places in 66f2a50249c5e2ebd05bac77c823c98d549830c7

parkr added a commit that referenced this pull request Feb 8, 2015

@parkr parkr closed this Feb 8, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 8, 2015

Member

Weird git thing happened. This was merged:

Member

parkr commented Feb 8, 2015

Weird git thing happened. This was merged:

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.