Added build --destination and --source flags #3418

Merged
merged 3 commits into from Mar 4, 2015

Conversation

Projects
None yet
4 participants
@tarebyte
Contributor

tarebyte commented Feb 6, 2015

From issue #3417

lib/jekyll/command.rb
@@ -49,6 +49,8 @@ def configuration_from_options(options)
# Returns nothing
def add_build_options(c)
c.option 'config', '--config CONFIG_FILE[,CONFIG_FILE2,...]', Array, 'Custom configuration file'
+ c.option 'destination', '--destination <destination>', 'The current folder will be generated into <destination>'
+ c.option 'source', '--source <source> --destination <destination>', 'The <source> folder will be generated into <destination>'

This comment has been minimized.

@parkr

parkr Feb 10, 2015

Member

?

This comment has been minimized.

@tarebyte

tarebyte Feb 10, 2015

Contributor

Is this not the correct place for these flags? Or are the flags not correct?

@tarebyte

tarebyte Feb 10, 2015

Contributor

Is this not the correct place for these flags? Or are the flags not correct?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 10, 2015

Member

Please also add the short versions, -s and -d.

Member

parkr commented Feb 10, 2015

Please also add the short versions, -s and -d.

lib/jekyll/command.rb
@@ -49,6 +49,8 @@ def configuration_from_options(options)
# Returns nothing
def add_build_options(c)
c.option 'config', '--config CONFIG_FILE[,CONFIG_FILE2,...]', Array, 'Custom configuration file'
+ c.option 'destination', '-d', '--destination <destination>', 'The current folder will be generated into <destination>'
+ c.option 'source', '-s', '--source <source> --destination <destination>', 'The <source> folder will be generated into <destination>'

This comment has been minimized.

@parkr

parkr Feb 10, 2015

Member

You can only have one switch per line, you cannot mix them.

--source <source> --destination <destination> is invalid.

@parkr

parkr Feb 10, 2015

Member

You can only have one switch per line, you cannot mix them.

--source <source> --destination <destination> is invalid.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 10, 2015

Member

Please also use SCREAMING_SNAKE_CASE instead of <brackets> for the argument fillers.

Member

parkr commented Feb 10, 2015

Please also use SCREAMING_SNAKE_CASE instead of <brackets> for the argument fillers.

@tarebyte

This comment has been minimized.

Show comment
Hide comment
@tarebyte

tarebyte Feb 10, 2015

Contributor

@parkr should be fixed now, thanks for the feedback!

Contributor

tarebyte commented Feb 10, 2015

@parkr should be fixed now, thanks for the feedback!

@tarebyte

This comment has been minimized.

Show comment
Hide comment
@tarebyte

tarebyte Feb 19, 2015

Contributor

@parkr does this need anything else added to it? I think I caught everything you mentioned.

Contributor

tarebyte commented Feb 19, 2015

@parkr does this need anything else added to it? I think I caught everything you mentioned.

envygeeks added a commit that referenced this pull request Mar 4, 2015

Merge pull request #3418 from tarebyte/destination-and-source
Added build --destination and --source flags

@envygeeks envygeeks merged commit d40b6d6 into jekyll:master Mar 4, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 4, 2015

Member

These are redundant because they're global: https://github.com/jekyll/jekyll/blob/master/bin/jekyll#L22-L26

They should be removed from being global if we want to do this, but that has implications for doctor and other commands that don't build.

Member

parkr commented Mar 4, 2015

These are redundant because they're global: https://github.com/jekyll/jekyll/blob/master/bin/jekyll#L22-L26

They should be removed from being global if we want to do this, but that has implications for doctor and other commands that don't build.

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.