write .jekyll-metadata even on full_rebuild #3464

Merged
merged 1 commit into from Feb 16, 2015

Conversation

Projects
None yet
4 participants
@willnorris
Contributor

willnorris commented Feb 15, 2015

For a full rebuild, we certainly don't want to read from .jeykll-metadata, but we should still write it. Otherwise, a subsequent incremental build would have to do a full rebuild again since there is no metadata file to start from.

/cc @alfredxing @mattr- to confirm

write .jekyll-metadata even on full_rebuild
For a full rebuild, we certainly don't want to *read* from
.jeykll-metadata, but we should still write it.  Otherwise, a subsequent
incremental build would have to do a full rebuild again since there is
no metadata file to start from.
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 15, 2015

Member

👍

Member

parkr commented Feb 15, 2015

👍

@parkr parkr added the fix label Feb 15, 2015

@alfredxing alfredxing self-assigned this Feb 16, 2015

alfredxing added a commit that referenced this pull request Feb 16, 2015

Merge pull request #3464 from willnorris/rebuild
write .jekyll-metadata even on full_rebuild

@alfredxing alfredxing merged commit 32cc745 into jekyll:master Feb 16, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@willnorris willnorris deleted the willnorris:rebuild branch Feb 22, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.