New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify pagination works from within HTML files #3467

Merged
merged 3 commits into from Apr 13, 2015

Conversation

Projects
None yet
3 participants
@jaybe-jekyll
Member

jaybe-jekyll commented Feb 15, 2015

IRC question of confusion re: wording and meaning.

Clarify pagination works from within HTML files
IRC question of confusion re: wording and meaning.
@parkr

View changes

Show outdated Hide outdated site/_docs/pagination.md
this for the list of Posts, this shouldn’t be an issue.
Pagination does not work from within Markdown or Textile files in your Jekyll site.
It will only work when called from within HTML files. For example, if you wanted
a paginated list of Posts, you would do so from within an HTML file, such as index.html.

This comment has been minimized.

@parkr

parkr Feb 16, 2015

Member

At the moment, we actually only allow index.html, so this note is a little too forgiving.

@parkr

parkr Feb 16, 2015

Member

At the moment, we actually only allow index.html, so this note is a little too forgiving.

This comment has been minimized.

@jaybe-jekyll

jaybe-jekyll Feb 16, 2015

Member

That's a rather important detail and likely one that would result in hair being pulled out if trying to go about it with anything other than index.html. I'll adapt it slightly.

Does v3 change this behavior? Thanks, Parker!

@jaybe-jekyll

jaybe-jekyll Feb 16, 2015

Member

That's a rather important detail and likely one that would result in hair being pulled out if trying to go about it with anything other than index.html. I'll adapt it slightly.

Does v3 change this behavior? Thanks, Parker!

This comment has been minimized.

@parkr

parkr Feb 17, 2015

Member

v3 has no changes for pagination, as pagination is a separate plugin.

@parkr

parkr Feb 17, 2015

Member

v3 has no changes for pagination, as pagination is a separate plugin.

This comment has been minimized.

@jaybe-jekyll

jaybe-jekyll Feb 17, 2015

Member

Thanks; I have updated the language; please review and merge if acceptable; thanks!

@jaybe-jekyll

jaybe-jekyll Feb 17, 2015

Member

Thanks; I have updated the language; please review and merge if acceptable; thanks!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 16, 2015

Member

Thanks!!

Member

parkr commented Feb 16, 2015

Thanks!!

@parkr parkr added the Documentation label Feb 16, 2015

Update pagination.md - Clarify only index.html
At this time, only index.html is allowed for pagination.
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 17, 2015

Member

Great! Maybe mention that index.html can be within subdirectories if you change your paginate_path? Is that appropriate here? It's just a little bit more flexible than what I read in your edits. 😃

Member

parkr commented Feb 17, 2015

Great! Maybe mention that index.html can be within subdirectories if you change your paginate_path? Is that appropriate here? It's just a little bit more flexible than what I read in your edits. 😃

@parkr parkr merged commit 3e030ea into jekyll:master Apr 13, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Apr 13, 2015

Merge branch 'jaybe-jekyll-patch-1'
* jaybe-jekyll-patch-1:
  Reformat note in pagination docs to use proper HTML. Ref #3467
  Clarify pagination file index.html may reside in subdirectory
  Update pagination.md - Clarify only index.html
  Clarify pagination works from within HTML files

parkr added a commit that referenced this pull request Apr 13, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.