New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented the "Improve this page" feature. #3495 #3510

Merged
merged 3 commits into from Feb 25, 2015

Conversation

Projects
None yet
4 participants
@MartinRogalla
Contributor

MartinRogalla commented Feb 24, 2015

Created an "Improve this page" link for all the documentation headers. The
feature uses the fa-pencil icon of font awesome. Improvement over #3504(closed).

See issue #3495 for more information.

Signed-off-by: Martin Jorn Rogalla martin@martinrogalla.com

Implemented the "Improve this page" feature. #3495
Created an "Improve this page" link for all the documentation headers. The
feature uses the fa-pencil icon of font awesome. Improvement over #3504(closed).

See issue #3495 for more information.

Signed-off-by: Martin Jorn Rogalla <martin@martinrogalla.com>
Removed unnecessary margin and simplified padding.
Signed-off-by: Martin Jorn Rogalla <martin@martinrogalla.com>
@troyswanson

This comment has been minimized.

Show comment
Hide comment
@troyswanson

troyswanson Feb 24, 2015

Member

I think the pencil icon should go before the text, but that's just me.

Member

troyswanson commented Feb 24, 2015

I think the pencil icon should go before the text, but that's just me.

Put the pencil icon in front of the improve link.
Signed-off-by: Martin Jorn Rogalla <martin@martinrogalla.com>
@MartinRogalla

This comment has been minimized.

Show comment
Hide comment
@MartinRogalla

MartinRogalla Feb 24, 2015

Contributor

Changed it. It does look better indeed.

Contributor

MartinRogalla commented Feb 24, 2015

Changed it. It does look better indeed.

@parkr parkr merged commit a4db7ec into jekyll:master Feb 25, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Feb 25, 2015

@rogierslag rogierslag deleted the delftswa2014:improve-this-page branch Mar 10, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.