Remove adapters deprecation warning #3529

Merged
merged 2 commits into from Mar 1, 2015

Conversation

Projects
None yet
3 participants
@fabianrbz
Member

fabianrbz commented Feb 28, 2015

Hi guys,

This pull request removes the following deprecation warning from simplecov.

The new way is using profiles. The warning comes from the gem 'simplecov-gem-adapter', which haven't been updated for the last 4 years.
In this pull request l removed the gem dependency and added a new profile with some of the settings that were in the gem. l thought it was better this way -instead of making a PR to the gem- because this way, we remove a dependency and it will be easier to customize the profile in the future.
What do you think?

Cheers!

fabianrbz added some commits Feb 28, 2015

Removes the following deprecation warning:
'method adapters is deprecated. use profiles instead'

This warning was showing up because the project was using
the gem 'simplecov-gem-adapter' which uses the old syntax.

* Remove the gem dependency
* Add a profile with the same setup that the gem has
+
+ add_group 'Binaries', '/bin/'
+ add_group 'Libraries', '/lib/'
+end

This comment has been minimized.

@parkr

parkr Feb 28, 2015

Member

Let's put this file in test.

@parkr

parkr Feb 28, 2015

Member

Let's put this file in test.

@@ -1,5 +1,4 @@
-require 'simplecov'
-require 'simplecov-gem-adapter'
+require 'simplecov_custom_profile'

This comment has been minimized.

@parkr

parkr Feb 28, 2015

Member

Please use File.expand_path to require this file.

@parkr

parkr Feb 28, 2015

Member

Please use File.expand_path to require this file.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Feb 28, 2015

Member

Great!!

Member

parkr commented Feb 28, 2015

Great!!

@parkr parkr added the fix label Mar 1, 2015

@parkr parkr merged commit e4b1382 into jekyll:master Mar 1, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Mar 1, 2015

@fabianrbz fabianrbz deleted the fabianrbz:remove_adapters_deprecation_warning branch Mar 1, 2015

@fabianrbz

This comment has been minimized.

Show comment
Hide comment
@fabianrbz

fabianrbz Mar 2, 2015

Member

@parkr thanks! what happened to the comments you made? were they implemented?

Member

fabianrbz commented Mar 2, 2015

@parkr thanks! what happened to the comments you made? were they implemented?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 2, 2015

Member

@parkr thanks! what happened to the comments you made? were they implemented?

Yep! fbe52bc

Member

parkr commented Mar 2, 2015

@parkr thanks! what happened to the comments you made? were they implemented?

Yep! fbe52bc

@fabianrbz

This comment has been minimized.

Show comment
Hide comment
@fabianrbz

fabianrbz Mar 3, 2015

Member

sweet! thanks @parkr!

Member

fabianrbz commented Mar 3, 2015

sweet! thanks @parkr!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.