Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Extract reading of data from `site.rb` to reduce responsibilities. #3545
I believe that the
My methodology per method:
Do you think this is a good idea at all or would you like it to be done differently?
I'm open to any criticism you might have.
Note: The usage of quotes is probably incorrect, I will fix these as soon as I know which style I should adhere to.
This is great stuff. I see places where you could push the refactoring further, but I think more pull requests can do that vs. holding this one up. I wrote a few questions, but I don't think they block merging this in.
I know you ended up moving stuff around quite a bit, but there's a bit of unnecessary noise in the diff (like the moving around of
All in all, I say