New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update permalinks docs #3556

Merged
merged 1 commit into from Mar 16, 2015

Conversation

Projects
None yet
6 participants
@willnorris
Contributor

willnorris commented Mar 9, 2015

This adds docs for two new permalink features coming in Jekyll 3:

  • improved default permalinks for pages and collections (#3538)
  • support for extensionless URLs (#3490)

There are a few places where I feel that the language isn't as smooth as it could be, but I want to go ahead and get these out for review.

@willnorris willnorris referenced this pull request Mar 9, 2015

Closed

URL Structure changes #3463

@chrisfinazzo

This comment has been minimized.

Show comment
Hide comment
@chrisfinazzo

chrisfinazzo Mar 12, 2015

Contributor

@willnorris,

Did you run rake test on this? Curious as to why the Travis build failed given that it's only checking a few Markdown files...

Contributor

chrisfinazzo commented Mar 12, 2015

@willnorris,

Did you run rake test on this? Curious as to why the Travis build failed given that it's only checking a few Markdown files...

@willnorris

This comment has been minimized.

Show comment
Hide comment
@willnorris

willnorris Mar 12, 2015

Contributor

yeah, tests work fine locally, not sure why travis is failing. Pushing a new commit to force travis to re-run.

Contributor

willnorris commented Mar 12, 2015

yeah, tests work fine locally, not sure why travis is failing. Pushing a new commit to force travis to re-run.

@willnorris

This comment has been minimized.

Show comment
Hide comment
@willnorris

willnorris Mar 12, 2015

Contributor

okay, tests are passing on travis now. I think circleci has just been generally flaky and not worth worrying about right now.

Contributor

willnorris commented Mar 12, 2015

okay, tests are passing on travis now. I think circleci has just been generally flaky and not worth worrying about right now.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 12, 2015

Member

linking out to personal websites and checking to make sure they're right is always annoying. it keeps our site working tho. @eduardoboucas, we're seeing an SSL error connecting to your site: https://circleci.com/gh/jekyll/jekyll/193 Do you have the intermediate and root certs in your cert chain?

Member

parkr commented Mar 12, 2015

linking out to personal websites and checking to make sure they're right is always annoying. it keeps our site working tho. @eduardoboucas, we're seeing an SSL error connecting to your site: https://circleci.com/gh/jekyll/jekyll/193 Do you have the intermediate and root certs in your cert chain?

@eduardoboucas

This comment has been minimized.

Show comment
Hide comment
@eduardoboucas

eduardoboucas Mar 12, 2015

Contributor

@parkr Sorry, I just updated my site to use HTTPS a couple of days ago and I've just realised that I was loading some external assets via HTTP. I removed those assets for now, so you shouldn't get the error now. Thanks!

Contributor

eduardoboucas commented Mar 12, 2015

@parkr Sorry, I just updated my site to use HTTPS a couple of days ago and I've just realised that I was loading some external assets via HTTP. I removed those assets for now, so you shouldn't get the error now. Thanks!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 12, 2015

Member

@eduardoboucas Thanks! I don't think it was that. The link is HTTP, so it gets a 301. We just have to update the link to use HTTPS and it should resolve itself. Would you mind submitting a PR?

Member

parkr commented Mar 12, 2015

@eduardoboucas Thanks! I don't think it was that. The link is HTTP, so it gets a 301. We just have to update the link to use HTTPS and it should resolve itself. Would you mind submitting a PR?

@eduardoboucas

This comment has been minimized.

Show comment
Hide comment
@eduardoboucas

eduardoboucas Mar 12, 2015

Contributor

Right! Sure thing, I'll do a PR.

Contributor

eduardoboucas commented Mar 12, 2015

Right! Sure thing, I'll do a PR.

@eduardoboucas

This comment has been minimized.

Show comment
Hide comment
Contributor

eduardoboucas commented Mar 12, 2015

@envygeeks envygeeks closed this in #3570 Mar 12, 2015

@envygeeks envygeeks reopened this Mar 12, 2015

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Mar 12, 2015

Contributor

Somehow this got closed when I merged the other one, sorry somehow 😢

Contributor

envygeeks commented Mar 12, 2015

Somehow this got closed when I merged the other one, sorry somehow 😢

update permalinks docs
This adds docs for two new permalink features coming in Jekyll 3:
 - improved default permalinks for pages and collections (#3538)
 - support for extensionless URLs (#3490)
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 16, 2015

Member

Yeah, this looks good! :shipit:

Member

parkr commented Mar 16, 2015

Yeah, this looks good! :shipit:

parkr added a commit that referenced this pull request Mar 16, 2015

@parkr parkr merged commit 3c9e43e into jekyll:master Mar 16, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Mar 16, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.