Remove loader.rb and "modernize" script/test. #3574

Merged
merged 1 commit into from Mar 16, 2015

Conversation

Projects
None yet
3 participants
@envygeeks
Contributor

envygeeks commented Mar 15, 2015

Fixes: #3573

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Mar 15, 2015

Contributor

Yeah I didn't mean "utitlize modernize". I meant just modernize.

Contributor

envygeeks commented Mar 15, 2015

Yeah I didn't mean "utitlize modernize". I meant just modernize.

@envygeeks envygeeks changed the title from Remove loader.rb and utilize "modernize" script/test. to Remove loader.rb and "modernize" script/test. Mar 15, 2015

@envygeeks envygeeks self-assigned this Mar 15, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 16, 2015

Member

I remember adding the loader in because rake wasn't available in Ruby 2.2 (just the lib files weren't there).

Member

parkr commented Mar 16, 2015

I remember adding the loader in because rake wasn't available in Ruby 2.2 (just the lib files weren't there).

@@ -1,23 +1,19 @@
#! /bin/bash
-#
+set -xe

This comment has been minimized.

@parkr

parkr Mar 16, 2015

Member

Could we live without x?

@parkr

parkr Mar 16, 2015

Member

Could we live without x?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 16, 2015

Member

👍

Member

parkr commented Mar 16, 2015

👍

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 16, 2015

Member

I remember adding the loader in because rake wasn't available in Ruby 2.2 (just the lib files weren't there).

Seems to have been fixed!

Member

parkr commented Mar 16, 2015

I remember adding the loader in because rake wasn't available in Ruby 2.2 (just the lib files weren't there).

Seems to have been fixed!

@parkr parkr added the :shipit: label Mar 16, 2015

parkr added a commit that referenced this pull request Mar 16, 2015

@parkr parkr merged commit 6a387b4 into master Mar 16, 2015

2 of 3 checks passed

ci/circleci Your tests failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@parkr parkr deleted the remove-legacy-loader branch Mar 16, 2015

parkr added a commit that referenced this pull request Mar 16, 2015

parkr added a commit that referenced this pull request Mar 16, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.