Perform jekyll-paginate deprecation warning correctly. #3580

Merged
merged 2 commits into from Mar 17, 2015

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Mar 16, 2015

Fixes #3393

Could you please try this out, @paulrobertlloyd?

@parkr parkr added this to the 3.0 milestone Mar 16, 2015

@paulrobertlloyd

This comment has been minimized.

Show comment
Hide comment
@paulrobertlloyd

paulrobertlloyd Mar 16, 2015

Contributor

Thanks for taking a look at this @parkr. Just tested this, but still getting the same deprecation message, sadly. Here is my Gemfile and Jekyll config. These look correct, right? I also checked that I was using this fix branch. Hmmm…

Contributor

paulrobertlloyd commented Mar 16, 2015

Thanks for taking a look at this @parkr. Just tested this, but still getting the same deprecation message, sadly. Here is my Gemfile and Jekyll config. These look correct, right? I also checked that I was using this fix branch. Hmmm…

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 16, 2015

Member

@paulrobertlloyd Try this rev?

Member

parkr commented Mar 16, 2015

@paulrobertlloyd Try this rev?

@paulrobertlloyd

This comment has been minimized.

Show comment
Hide comment
@paulrobertlloyd

paulrobertlloyd Mar 16, 2015

Contributor

@parkr Bingo! That works as expected. Thank-you!

Contributor

paulrobertlloyd commented Mar 16, 2015

@parkr Bingo! That works as expected. Thank-you!

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 17, 2015

Member

:dance:

Member

parkr commented Mar 17, 2015

:dance:

parkr added a commit that referenced this pull request Mar 17, 2015

@parkr parkr merged commit 333b9f5 into master Mar 17, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@parkr parkr deleted the fix-3393 branch Mar 17, 2015

parkr added a commit that referenced this pull request Mar 17, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.