New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should this have the "Warning" label? #3623

Merged
merged 4 commits into from Apr 10, 2015

Conversation

Projects
None yet
3 participants
@chrisfinazzo
Contributor

chrisfinazzo commented Mar 27, 2015

No description provided.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 27, 2015

Member

The entire section is called Gotchas so not sure if it makes sense here. :)

Member

parkr commented Mar 27, 2015

The entire section is called Gotchas so not sure if it makes sense here. :)

@chrisfinazzo

This comment has been minimized.

Show comment
Hide comment
@chrisfinazzo

chrisfinazzo Mar 27, 2015

Contributor

I know, this is kind of iffy. I wonder if we really need an entire section, as there's only one item there (Just stop at 3). I put it out here because the consequences of not following this instruction in a Travis setup is so bad. The only other place I could see putting this would be under Troubleshooting, but I'm not sure it belongs there.

Contributor

chrisfinazzo commented Mar 27, 2015

I know, this is kind of iffy. I wonder if we really need an entire section, as there's only one item there (Just stop at 3). I put it out here because the consequences of not following this instruction in a Travis setup is so bad. The only other place I could see putting this would be under Troubleshooting, but I'm not sure it belongs there.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Mar 27, 2015

Member

I wonder if we really need an entire section, as there's only one item there (Just stop at 3).

👍

Member

parkr commented Mar 27, 2015

I wonder if we really need an entire section, as there's only one item there (Just stop at 3).

👍

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 8, 2015

Member

Can you also put the highlight in the body of that note?

Member

parkr commented Apr 8, 2015

Can you also put the highlight in the body of that note?

@chrisfinazzo

This comment has been minimized.

Show comment
Hide comment
@chrisfinazzo

chrisfinazzo Apr 8, 2015

Contributor

Like this?

screen shot 2015-04-08 at 3 57 57 pm

That's...OK. I guess that's one way to do it. 😕

Contributor

chrisfinazzo commented Apr 8, 2015

Like this?

screen shot 2015-04-08 at 3 57 57 pm

That's...OK. I guess that's one way to do it. 😕

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 8, 2015

Member

oh ew.

Member

parkr commented Apr 8, 2015

oh ew.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 8, 2015

Member

what does it look like now?

Member

parkr commented Apr 8, 2015

what does it look like now?

parkr added a commit that referenced this pull request Apr 10, 2015

@parkr parkr merged commit 12b16dd into jekyll:master Apr 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Apr 10, 2015

@chrisfinazzo chrisfinazzo deleted the chrisfinazzo:ci-docs branch Apr 10, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.