Removed unused method StaticFile::extname #3632

Merged
merged 1 commit into from Apr 10, 2015

Conversation

Projects
None yet
3 participants
@mdenhoedt
Contributor

mdenhoedt commented Apr 1, 2015

I have removed the unused method StaticFile::extname. The method is not used by any test and doesn't add value. Everywhere File.extname(path) is called directly, therefore StaticFile::extname is useless.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 1, 2015

Member

We should cache the return value of File.extname(filename).

Member

parkr commented Apr 1, 2015

We should cache the return value of File.extname(filename).

@parkr parkr closed this Apr 1, 2015

@parkr parkr reopened this Apr 1, 2015

@mdenhoedt

This comment has been minimized.

Show comment
Hide comment
@mdenhoedt

mdenhoedt Apr 1, 2015

Contributor

@parkr as you did in pull request #3596? I think that is a good idea, but still this method remains unused, or am I missing something?

Contributor

mdenhoedt commented Apr 1, 2015

@parkr as you did in pull request #3596? I think that is a good idea, but still this method remains unused, or am I missing something?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 8, 2015

Member

@mdenhoedt Yes! Want to submit a PR to my PR? :)

Member

parkr commented Apr 8, 2015

@mdenhoedt Yes! Want to submit a PR to my PR? :)

@parkr parkr merged commit f0cac68 into jekyll:master Apr 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Apr 10, 2015

Merge branch 'delftswa2014-remove-unused-method'
* delftswa2014-remove-unused-method:
  static_file: extract extname in initializer and save as variable. #3632
  removed unused method StaticFile::extname

parkr added a commit that referenced this pull request Apr 10, 2015

@JoopAue JoopAue deleted the delftswa2014:remove-unused-method branch Apr 24, 2015

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.