Add WOFF2 font format #3647

Merged
merged 1 commit into from Apr 10, 2015

Conversation

Projects
None yet
6 participants
@nhoizey
Contributor

nhoizey commented Apr 9, 2015

No description provided.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 9, 2015

Member

@azizshamim Is this in the GHP mime types file? We're trying to maintain parity.

Member

parkr commented Apr 9, 2015

@azizshamim Is this in the GHP mime types file? We're trying to maintain parity.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 10, 2015

Contributor

I don't know how he would know that because he doesn't have access to their servers?

Contributor

envygeeks commented Apr 10, 2015

I don't know how he would know that because he doesn't have access to their servers?

@alfredxing

This comment has been minimized.

Show comment
Hide comment
@alfredxing

alfredxing Apr 10, 2015

Member

I created a test repo, and it seems that WOFF files are served as application/x-font-woff (as expected), but WOFF2 files are still being served as application/octet-stream, which probably means GitHub hasn't added this on their end yet.

Member

alfredxing commented Apr 10, 2015

I created a test repo, and it seems that WOFF files are served as application/x-font-woff (as expected), but WOFF2 files are still being served as application/octet-stream, which probably means GitHub hasn't added this on their end yet.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 10, 2015

Member

I don't know how he would know that because he doesn't have access to their servers?

@envygeeks Aziz works on GitHub's infrastructure. He knows. :)

@alfredxing Ok, then it's time for a support request! I'll send it now.

Member

parkr commented Apr 10, 2015

I don't know how he would know that because he doesn't have access to their servers?

@envygeeks Aziz works on GitHub's infrastructure. He knows. :)

@alfredxing Ok, then it's time for a support request! I'll send it now.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 10, 2015

Member

On hold at the moment. Got a response from GitHub, but the W3C spec doesn't specify this MIME Type (and is vague about which one to use).

Member

parkr commented Apr 10, 2015

On hold at the moment. Got a response from GitHub, but the W3C spec doesn't specify this MIME Type (and is vague about which one to use).

@parkr parkr added the Enhancement label Apr 10, 2015

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 10, 2015

Contributor

The spec states application/font-woff2 which will more than likely be what it will land as in the final spec.

Contributor

envygeeks commented Apr 10, 2015

The spec states application/font-woff2 which will more than likely be what it will land as in the final spec.

@parkr

This comment has been minimized.

Show comment
Hide comment

parkr added a commit that referenced this pull request Apr 10, 2015

@parkr parkr merged commit 6d6c15e into jekyll:master Apr 10, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

parkr added a commit that referenced this pull request Apr 10, 2015

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 10, 2015

Member

I'm convinced! Thanks. 😄

Member

parkr commented Apr 10, 2015

I'm convinced! Thanks. 😄

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 10, 2015

Member

/cc @jdennes ❤️

Member

parkr commented Apr 10, 2015

/cc @jdennes ❤️

@nhoizey

This comment has been minimized.

Show comment
Hide comment
@nhoizey

nhoizey Apr 10, 2015

Contributor

\o/

Thanks!

Contributor

nhoizey commented Apr 10, 2015

\o/

Thanks!

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 10, 2015

Contributor

❤️

Contributor

envygeeks commented Apr 10, 2015

❤️

@jdennes

This comment has been minimized.

Show comment
Hide comment
@jdennes

jdennes Apr 12, 2015

We've deployed the corresponding change on the GitHub side. GitHub Pages will now serve .woff2 files with a Content-Type header value of application/font-woff2.

jdennes commented Apr 12, 2015

We've deployed the corresponding change on the GitHub side. GitHub Pages will now serve .woff2 files with a Content-Type header value of application/font-woff2.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 12, 2015

Member

Thank you so much @jdennes!!!!!!!

Member

parkr commented Apr 12, 2015

Thank you so much @jdennes!!!!!!!

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.