Change access of collection in iteration. #3670

Merged
merged 2 commits into from Apr 29, 2015

Conversation

Projects
None yet
4 participants
@parkr
Member

parkr commented Apr 20, 2015

Not sure if this is going to break a lot of sites, but we've talk about it for a while.

Replaces #3349, fixes #2346.

@envygeeks

This comment has been minimized.

Show comment
Hide comment
@envygeeks

envygeeks Apr 21, 2015

Contributor

Shouldn't the Minitest assertions be a pull of it's own for the sake of tracking?

Contributor

envygeeks commented Apr 21, 2015

Shouldn't the Minitest assertions be a pull of it's own for the sake of tracking?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 23, 2015

Member

Sure!

Member

parkr commented Apr 23, 2015

Sure!

@parkr parkr added this to the 3.0 milestone Apr 29, 2015

@parkr parkr added the Enhancement label Apr 29, 2015

parkr added a commit that referenced this pull request Apr 29, 2015

@parkr parkr merged commit e5bbdb1 into master Apr 29, 2015

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@parkr parkr deleted the bernardodiasc-collections branch Apr 29, 2015

parkr added a commit that referenced this pull request Apr 29, 2015

@pathawks pathawks referenced this pull request in jekyll/jekyll-sitemap Aug 31, 2015

Closed

generating collections in sitemap 3 beta #80

@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.